-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46925/#review131513
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
 (line 149)
<https://reviews.apache.org/r/46925/#comment195518>

    Nit: The existing formatting has the closing parenthesis on a new line 
aligned at the first column :-)


- Nahappan Somasundaram


On May 3, 2016, 7:29 a.m., Sumit Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46925/
> -----------------------------------------------------------
> 
> (Updated May 3, 2016, 7:29 a.m.)
> 
> 
> Review request for Ambari, Nahappan Somasundaram and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-16209
>     https://issues.apache.org/jira/browse/AMBARI-16209
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Write out new log property files under /etc/hive2/conf
> llap-daemon-log4j2.properties (from llap-daemon-log4j2.properties.template)
> llap-cli-log4j2.properties (from llap-cli-log4j2.properties.template)
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  24047ff 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  2e1a2af 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-cli-log4j2.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml
>  1c60285 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> 5712995 
>   ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json e7bb056 
> 
> Diff: https://reviews.apache.org/r/46925/diff/
> 
> 
> Testing
> -------
> 
> Ran unit tests.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Reply via email to