----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47119/#review132276 -----------------------------------------------------------
Fix it, then Ship it! Overal the patch looks fine to me, just with a few minor issues below that need clarification. One additional question: How is the filter itself configured to a specific log level? Shouldn't there be some new stack properties included that allow the user to select the levels to include in the filter? Thanks. ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py (line 275) <https://reviews.apache.org/r/47119/#comment196465> This property doesn't appear to be listed in the stack definition above. Is this intentional? ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2 (line 21) <https://reviews.apache.org/r/47119/#comment196466> Should this property ever be configured by a user, or should this value always be "history"? - Robert Nettleton On May 9, 2016, 2 p.m., Oliver Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47119/ > ----------------------------------------------------------- > > (Updated May 9, 2016, 2 p.m.) > > > Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit > Mohanty. > > > Bugs: AMBARI-16305 > https://issues.apache.org/jira/browse/AMBARI-16305 > > > Repository: ambari > > > Description > ------- > > Add abilliy to disable/enable log level filter on LogFeeder side (default: > enabled) > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml > 2e92ab9 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py > 97ad191 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2 > 2408261 > ambari-web/app/data/HDP2/site_properties.js 45c54a0 > > Diff: https://reviews.apache.org/r/47119/diff/ > > > Testing > ------- > > Total run:1014 > Total errors:0 > Total failures:0 > > > Thanks, > > Oliver Szabo > >
