> On May 6, 2016, 10:12 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > line 198 > > <https://reviews.apache.org/r/47026/diff/1/?file=1373607#file1373607line198> > > > > I don't think we need the word "ambari" in an Ambari database table. > > Gaurav Nagar wrote: > remoteambaricluster indicates remote cluster managed by ambari. > > Jonathan Hurley wrote: > I think that's implied though - what other kinds of remote clusters are > there? > > Gaurav Nagar wrote: > Currently we have only ambari managed. But in future we can have remote > clusters that are not managed by ambari also. > > Jonathan Hurley wrote: > In that case, wouldn't it still be a remotecluster of a different type? > Not a different table entirely?
Discussed and it was my misunderstanding that remote clusters and remote ambari clusters wouldn't really share any common data, so there should separate tables for these (instead of a column type) - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47026/#review132026 ----------------------------------------------------------- On May 9, 2016, 9:44 a.m., Gaurav Nagar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47026/ > ----------------------------------------------------------- > > (Updated May 9, 2016, 9:44 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj > Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16274 > https://issues.apache.org/jira/browse/AMBARI-16274 > > > Repository: ambari > > > Description > ------- > > Added tables for Remote Cluster to create scripts. > Added table changes to UpgradeCatalog240 > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > f85a4c7 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f5336bc > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql fca3be3 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ce0bd84 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7fb8c31 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > 0f3a2c2 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql b89389c > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 1107c4d > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java > 7c85ba7 > > Diff: https://reviews.apache.org/r/47026/diff/ > > > Testing > ------- > > Manual Testing. > > > Thanks, > > Gaurav Nagar > >
