> On May 6, 2016, 1:53 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteAmbariClusterEntity.java, > > lines 83-86 > > <https://reviews.apache.org/r/47023/diff/1/?file=1373567#file1373567line83> > > > > Is this really a M2M relationship? RemoteClusterServiceEntity are > > shared between clusters? > > Gaurav Nagar wrote: > Yes RemoteClusterServiceEntity is shared between clusters.
Does it need to be? If you kept it 1:M so that a single remote cluster had a bunch of remote services, but those services were only for that cluster, it would make keeping the bi-directional relationship simpler. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47023/#review132081 ----------------------------------------------------------- On May 9, 2016, 1:09 p.m., Gaurav Nagar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47023/ > ----------------------------------------------------------- > > (Updated May 9, 2016, 1:09 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj > Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16274 > https://issues.apache.org/jira/browse/AMBARI-16274 > > > Repository: ambari > > > Description > ------- > > Added RemotAmbariClusterEntity, RemoteAmbariClusterDao to store remote > cluster credential. > Added RemoteClusterResourceProvider for accessing Remote Cluster through api. > Added RemoteAmbariCluster impementation for view.Cluster that can be accessed > through ViewContextImpl. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/RemoteClusterResourceDefinition.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java > 0b77511 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RemoteClustersService.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java > 4e7a032 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProvider.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java > 605f68d > > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java > 386e657 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RemoteAmbariClusterDAO.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RemoteClusterServiceDAO.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteAmbariClusterEntity.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteAmbariClusterServiceEntity.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteClusterServiceEntity.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java > 29dc2a7 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java > 2d6e5ba > > ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariCluster.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariClusterRegistry.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariConfigurationReadException.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariStreamProvider.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewAmbariStreamProvider.java > 1dacd92 > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java > ba7f446 > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > d2d48a9 > > ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java > bb6a93c > ambari-server/src/main/resources/META-INF/persistence.xml ce563cb > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProviderTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/view/RemoteAmbariClusterTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewAmbariStreamProviderTest.java > 8549d4a > > ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java > a41e137 > > Diff: https://reviews.apache.org/r/47023/diff/ > > > Testing > ------- > > Manual Testing > > > Thanks, > > Gaurav Nagar > >