> On May 10, 2016, 5:01 a.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertStateChangedListener.java, > > line 192 > > <https://reviews.apache.org/r/47140/diff/1/?file=1377196#file1377196line192> > > > > "the an"? Don't fix unless there are other changes.
Thx for the review. Comments are as important as the code itself - I'm fixing it!!! :) - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47140/#review132394 ----------------------------------------------------------- On May 9, 2016, 7:36 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47140/ > ----------------------------------------------------------- > > (Updated May 9, 2016, 7:36 p.m.) > > > Review request for Ambari and Robert Levas. > > > Bugs: AMBARI-16410 > https://issues.apache.org/jira/browse/AMBARI-16410 > > > Repository: ambari > > > Description > ------- > > Ambari reports alerts and triggers notifications during a stack upgrade. In > most cases, alert notifications should be suppressed during the upgrade to > prevent false positives. > > However, some alerts, such as those which don't related to the cluster, > should remain fully operational: > > - Host disk space > - Upgrade not finalized > - Ambari Server Performance > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertStateChangedListener.java > 21584fb > > ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java > f76867a > > Diff: https://reviews.apache.org/r/47140/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Jonathan Hurley > >
