----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46944/ -----------------------------------------------------------
(Updated May 10, 2016, 4:19 p.m.) Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Myroslav Papirkovskyy, Sumit Mohanty, and Sebastian Toader. Changes ------- removed volatile keyword Bugs: AMBARI-16230 https://issues.apache.org/jira/browse/AMBARI-16230 Repository: ambari Description ------- 2 different type of errors can occur during adding any new service to Ambari: org.apache.ambari.server.AmbariException: Unable to create a default alert group for unknown service <SERVICE_NAME> in cluster org.apache.ambari.server.ServiceNotFoundException: Service not found, clusterName=c1, serviceName=<SERVICE_NAME> The reason is that: ServiceInstalledEvent can be handled quicker than ServiceImpl.persist() can finish Diffs (updated) ----- ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 47342f3 ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 487489b ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java f38c25a ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java a3d05a9 ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 19146fd ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java d1b27a9 ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java 1875ba6 Diff: https://reviews.apache.org/r/46944/diff/ Testing ------- Unit Testing is in progress.. FT: added new services about 10 times, has no any errors thrown. Thanks, Oliver Szabo