> On May 12, 2016, 1:59 p.m., DIPAYAN BHOWMICK wrote: > > Ship It!
Remove the console.logs - DIPAYAN ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47175/#review132901 ----------------------------------------------------------- On May 12, 2016, 12:51 p.m., Nitiraj Rathore wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47175/ > ----------------------------------------------------------- > > (Updated May 12, 2016, 12:51 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, and Ashwin Rajeev. > > > Bugs: AMBARI-16422 > https://issues.apache.org/jira/browse/AMBARI-16422 > > > Repository: ambari > > > Description > ------- > > Earliar : UI should show validation error cue to the user for fields like > column names and table name if illegal names are present. > > In this Patch : added new component for UI validation of text fields through > regex. It will show red border around invalid values. > > > Diffs > ----- > > > contrib/views/hive/src/main/resources/ui/hive-web/app/components/validated-text-field.js > PRE-CREATION > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js > d883743 > contrib/views/hive/src/main/resources/ui/hive-web/app/styles/app.scss > 8f60595 > > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/validated-text-field.hbs > PRE-CREATION > > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs > b7d9011 > > Diff: https://reviews.apache.org/r/47175/diff/ > > > Testing > ------- > > Manual testing done. > > > Thanks, > > Nitiraj Rathore > >