----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47304/#review132900 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java (lines 1367 - 1370) <https://reviews.apache.org/r/47304/#comment197178> VDFXml.build() might throw an exception like a NPE; should we try/catch this to prevent problems on server start. - Jonathan Hurley On May 12, 2016, 8:25 a.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47304/ > ----------------------------------------------------------- > > (Updated May 12, 2016, 8:25 a.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley. > > > Bugs: AMBARI-16462 > https://issues.apache.org/jira/browse/AMBARI-16462 > > > Repository: ambari > > > Description > ------- > > For enabled stacks, create VDF for consumption from the > /api/v1/version_definitions endpoint. This is available via the > {{show_available}} option, but will create VDF based on stack information > ({{repoinfo.xml}}). > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > 77f2ede > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java > 94b9648 > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java > 6129ec0 > ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java > 9fb6106 > > ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java > 3111a4a > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java > fc2bab1 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java > 1117d24 > > Diff: https://reviews.apache.org/r/47304/diff/ > > > Testing > ------- > > Manual. Automated: > > > Tests run: 4326, Failures: 0, Errors: 0, Skipped: 34 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 33:54.528s > [INFO] Finished at: Thu May 12 07:46:59 EDT 2016 > [INFO] Final Memory: 35M/703M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
