> On May 12, 2016, 10:40 a.m., Jonathan Hurley wrote: > > ambari-server/docs/api/v1/permission-get.md, line 75 > > <https://reviews.apache.org/r/47237/diff/1/?file=1379646#file1379646line75> > > > > The official label is going to have an abbreviated word in it?
Yup.. :| > On May 12, 2016, 10:40 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java, > > line 383 > > <https://reviews.apache.org/r/47237/diff/1/?file=1379647#file1379647line383> > > > > Why not just extend the > > PermissionEntity.AMBARI_ADMINISTRATOR_PERMISSION_NAME to be an enum which > > contains botht he label and the name? Seems like instead of > > literal-stringing it all over the place, it would be better to encapsulate > > these in an enum. Ideally this value is taken from the database. This is to help with future proofing for when we allow users to create their own roles (shhh... you didn't hear that from me, but I think it makes sense to prepare for this because I think it should eventually be a feature). - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47237/#review132916 ----------------------------------------------------------- On May 11, 2016, 10:06 a.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47237/ > ----------------------------------------------------------- > > (Updated May 11, 2016, 10:06 a.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, and Richard Zang. > > > Bugs: AMBARI-16449 > https://issues.apache.org/jira/browse/AMBARI-16449 > > > Repository: ambari > > > Description > ------- > > Change permission_label for role AMBARI.ADMINISTRATOR from "Administrator" to > "Ambari Admin" > > > Diffs > ----- > > ambari-server/docs/api/v1/permission-get.md d949344 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java > 2389d0d > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql d77a0b3 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 22413e0 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 6000d24 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 67bd38a > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > ea7ab7a > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 1c3393e > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 2245f77 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java > 67a94ea > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProviderTest.java > f03d240 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PermissionResourceProviderTest.java > bcfae8d > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProviderTest.java > 4e0ba24 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog230Test.java > 6cf520d > > Diff: https://reviews.apache.org/r/47237/diff/ > > > Testing > ------- > > Manually tested upgrade and new instance creation. > > # Local test results: PENDING > > # Jenkins test results: PENDING > > > Thanks, > > Robert Levas > >
