----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47459/#review133776 -----------------------------------------------------------
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/ValidatorUtils.java (line 32) <https://reviews.apache.org/r/47459/#comment198371> This isn't directly related to this patch, but you might want to be aware that there are other schemes for S3-backed file system implementations. In addition to "s3", Hadoop also has "s3n" and "s3a". There are more details here: http://hadoop.apache.org/docs/r2.7.2/hadoop-aws/tools/hadoop-aws/index.html contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java (line 268) <https://reviews.apache.org/r/47459/#comment198373> It looks like Ambari is relying on the scheme name to detect the default file system. This pattern is already in place in the `configureWASB` method. Just FYI, Hadoop supports configuration flexibility so that a different scheme name maps to the file system implementation. For example, someone could theoretically configure "myadl" to map to the `AdlFileSystem` class, and then this detection logic wouldn't work. This is an edge case though and probably not something that needs to be addressed within the scope of this patch. - Chris Nauroth On May 17, 2016, 2:58 p.m., Gaurav Nagar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47459/ > ----------------------------------------------------------- > > (Updated May 17, 2016, 2:58 p.m.) > > > Review request for Ambari, Chris Nauroth, DIPAYAN BHOWMICK, Nitiraj Rathore, > Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16706 > https://issues.apache.org/jira/browse/AMBARI-16706 > > > Repository: ambari > > > Description > ------- > > Added adl related properties > > > Diffs > ----- > > contrib/views/utils/pom.xml c15afad > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/ValidatorUtils.java > c936355 > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java > 8b45cd6 > > Diff: https://reviews.apache.org/r/47459/diff/ > > > Testing > ------- > > Manually Tested > > > Thanks, > > Gaurav Nagar > >
