----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47541/#review134048 -----------------------------------------------------------
Ship it! Ship It! - Jayush Luniya On May 18, 2016, 4:41 p.m., Juanjo Marron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47541/ > ----------------------------------------------------------- > > (Updated May 18, 2016, 4:41 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. > > > Bugs: AMBARI-16408 > https://issues.apache.org/jira/browse/AMBARI-16408 > > > Repository: ambari > > > Description > ------- > > Python code at at common-services level used generic imports form > resource_management (from resource_management import *) > Ideally, for easier code tracking and performance, these import should be > more specific, such as: > from resource_management.libraries.script.script import Script > from resource_management.core.resources.system import Directory > This patch cleans up import * from resource_management for Hive service > scripts in common-services > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py > d2f28f5 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py > f35a570 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_decommission.py > 022465a > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py > 840411f > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py > 4001912 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_service.py > a6904f6 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_upgrade.py > 2dc9883 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_windows.py > 7d634cb > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py > 6ecb58e > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/upgrade.py > b1a19e6 > > Diff: https://reviews.apache.org/r/47541/diff/ > > > Testing > ------- > > Pass mvn clean test -DskipSurefireTests > Hbase fresh installation and service check > > Hadoop QA added a comment - 2 hours ago > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12803349/AMBARI-16408.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/6878//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/6878//console > > > Thanks, > > Juanjo Marron > >