----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47653/ -----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. Bugs: AMBARI-16672 https://issues.apache.org/jira/browse/AMBARI-16672 Repository: ambari Description ------- Python code at at common-services level used generic imports form resource_management (from resource_management import *) Ideally, for easier code tracking and performance, these import should be more specific, such as: from resource_management.libraries.script.script import Script from resource_management.core.resources.system import Directory This patch cleans up import * from resource_management for OOzie service scripts in common-services Diffs ----- ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py b3c6537 ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py 3060353 ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 75924c5 Diff: https://reviews.apache.org/r/47653/diff/ Testing ------- Pass mvn clean test -DskipSurefireTests OOZIE fresh installation and service check Hadoop QA added a comment - 4 minutes ago -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12804552/AMBARI-16672.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in ambari-server. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/6920//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/6920//console This message is automatically generated. Thanks, Juanjo Marron