> On May 23, 2016, 9:09 a.m., Dmytro Sen wrote: > > Ship It!
Dmytro, thank you so much for your quick response! I really appreciate it. - Qin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47701/#review134322 ----------------------------------------------------------- On May 23, 2016, 5:59 a.m., Qin Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47701/ > ----------------------------------------------------------- > > (Updated May 23, 2016, 5:59 a.m.) > > > Review request for Ambari, Dmytro Sen and Sid Wagle. > > > Bugs: AMBARI-16642 > https://issues.apache.org/jira/browse/AMBARI-16642 > > > Repository: ambari > > > Description > ------- > > After enabling HTTPS for YARN, "NodeManager GC Time" and "NodeManager JVM > Heap Memory Used" widgets on YARN Heatmaps show NA. The root cause is that > yarn.nodemanager.webapp.address rather than > yarn.nodemanager.webapp.https.address is used to get JMX metrics. > > Steps to reproduce: > 1. install a cluster with default from Ambari Web UI. > 2. configuring SSL for HDFS, YARN, and MapReduce. > 3. enable HTTPS for YARN > 1). Set the following property in Advanced yarn-site from Ambari Web UI: > yarn.http.policy=HTTPS_ONLY > 2). Add the following property in Custom yarn-site from Ambari Web UI: > yarn.nodemanager.webapp.https.address=0.0.0.0:8044 > 4. "NodeManager GC Time" and "NodeManager JVM Heap Memory Used" widgets on > YARN Heatmaps will show NA. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java > 36be39e > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java > a6e5501 > > Diff: https://reviews.apache.org/r/47701/diff/ > > > Testing > ------- > > 1. The fix has been tested with HDP UI > "NodeManager GC Time" and "NodeManager JVM Heap Memory Used" metrics show up > after apply the fix. > > 2. JMXHostProviderTest.java has been modified to verify JMX protocol and port > for NodeManager. > Test set: org.apache.ambari.server.controller.internal.JMXHostProviderTest > ------------------------------------------------------------------------------- > Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 120.274 sec - > in org.apache.ambari.server.controller.internal.JMXHostProviderTest > > 3. The latest result of running ambari-server tests: > Results : > Failed tests: > DataStoreImplTest.testFind:409 > Unexpected method call EntityManager.getDelegate(): > EntityManager.find(capture(Nothing captured yet), 99): expected: 1, > actual: 0 > EntityManager.close(): expected: 1, actual: 0 > DataStoreImplTest.testFindAll:453 > Unexpected method call EntityManager.getDelegate(): > EntityManager.createQuery("SELECT e FROM > DS_DataStoreImplTest$TestEntity_1 e WHERE e.DS_id=99"): expected: 1, actual: 0 > EntityManager.close(): expected: 1, actual: 0 > DataStoreImplTest.testFindAll_multiple:518 > Unexpected method call EntityManager.getDelegate(): > EntityManager.createQuery("SELECT e FROM > DS_DataStoreImplTest$TestEntity_1 e WHERE e.DS_name='foo'"): expected: 1, > actual: 0 > EntityManager.close(): expected: 1, actual: 0 > DataStoreImplTest.testRemove:370 > Unexpected method call EntityManager.getDelegate(): > EntityManager.getReference(capture(Nothing captured yet), 99): expected: > 1, actual: 0 > EntityManager.remove(EasyMock for interface > org.eclipse.persistence.dynamic.DynamicEntity): expected: 1, actual: 0 > EntityManager.close(): expected: 1, actual: 0 > DataStoreImplTest.testStore_create:128 > Unexpected method call EntityManager.getDelegate(): > EntityManager.find(capture(Nothing captured yet), "bar"): expected: 1, > actual: 0 > EntityManager.find(capture(Nothing captured yet), 99): expected: 1, > actual: 0 > EntityManager.persist(capture(Nothing captured yet)): expected: 1, > actual: 0 > EntityManager.persist(capture(Nothing captured yet)): expected: 1, > actual: 0 > EntityManager.close(): expected: 1, actual: 0 > DataStoreImplTest.testStore_create_largeEntity:222 > Unexpected method call EntityManager.getDelegate(): > EntityManager.close(): expected: 1, actual: 0 > DataStoreImplTest.testStore_create_longStringValue:182 > Unexpected method call EntityManager.getDelegate(): > EntityManager.find(capture(Nothing captured yet), 99): expected: 1, > actual: 0 > EntityManager.close(): expected: 1, actual: 0 > DataStoreImplTest.testStore_update:276 > Unexpected method call EntityManager.getDelegate(): > EntityManager.find(capture(Nothing captured yet), "bar"): expected: 1, > actual: 0 > EntityManager.find(capture(Nothing captured yet), 99): expected: 1, > actual: 0 > EntityManager.persist(capture(Nothing captured yet)): expected: 1, > actual: 0 > EntityManager.close(): expected: 1, actual: 0 > DataStoreImplTest.testStore_update_longStringValue:328 > Unexpected method call EntityManager.getDelegate(): > EntityManager.find(capture(Nothing captured yet), 99): expected: 1, > actual: 0 > EntityManager.close(): expected: 1, actual: 0 > Tests in error: > PersistKeyValueImplTest.testMultiThreaded:103 » OutOfMemory unable to > create n... > UpgradeCatalog240Test.testExecuteDMLUpdates:524 » NullPointer > Tests run: 4363, Failures: 9, Errors: 2, Skipped: 34 > > Need to mention that I got above failure even without my fix. > > > File Attachments > ---------------- > > AMBARI-16642.patch > > https://reviews.apache.org/media/uploaded/files/2016/05/22/f40fa1d3-53e0-4e52-988a-b1b128d01cfc__AMBARI-16642.patch > > > Thanks, > > Qin Liu > >
