> On máj. 24, 2016, 4:03 de, Swapan Shridhar wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py, > > line 221 > > <https://reviews.apache.org/r/47596/diff/2/?file=1388878#file1388878line221> > > > > Can you explain how moving this line up helps ? Thx.
I moved it up to make sure that this setting has a correct value all the time, even if calculations are skipped. Skip points have been added, so tracking them and add this value everywhere would not be a good solution. Moving the line up makes sure that the initial value for that property is correct, but later in the function it can be overwritten with a calculated value (if those parts are not skipped). If the memory setting is not correct, then hive interactive server won't start. - Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47596/#review134511 ----------------------------------------------------------- On máj. 23, 2016, 8:20 de, Daniel Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47596/ > ----------------------------------------------------------- > > (Updated máj. 23, 2016, 8:20 de) > > > Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, Sumit > Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-16776 > https://issues.apache.org/jira/browse/AMBARI-16776 > > > Repository: ambari > > > Description > ------- > > Default value of hive.llap.daemon.yarn.container.mb is not aligned to > yarn.scheduler.minimum-allocation-mb > If the former one is less than the latter one, then hive server interactive > wont start. So the default values must be in a proper relation. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 9f5d799 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml > db5f616 > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > 11aac72 > > Diff: https://reviews.apache.org/r/47596/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 2:15.746s > [INFO] Finished at: Thu May 19 18:52:43 CEST 2016 > [INFO] Final Memory: 58M/1120M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Daniel Gergely > >
