Re: Review Request 47417: Replace '*' to hdp version in lzo packages

[Vitalyi Brodetskyi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47417/
-----------------------------------------------------------

(Updated Травень 24, 2016, 2:32 після полудня)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sumit 
Mohanty.


Bugs: AMBARI-16683
    https://issues.apache.org/jira/browse/AMBARI-16683


Repository: ambari


Description
-------

As i understood(according to discussion with Andrew O) we had some jira for '*' 
to hdp version replacement in all packages. But here it was not replaced:
{code}
def get_lzo_packages(stack_version_unformatted):
  lzo_packages = []
 
  if OSCheck.is_redhat_family() or OSCheck.is_suse_family():
    lzo_packages += ["lzo", "hadoop-lzo-native"]
  elif OSCheck.is_ubuntu_family():
    lzo_packages += ["liblzo2-2"]

  if stack_version_unformatted and 
check_stack_feature(StackFeature.ROLLING_UPGRADE, stack_version_unformatted):
    lzo_packages += ["hadooplzo_*"]
  else:
    lzo_packages += ["hadoop-lzo"]

  return lzo_packages
{code}


Diffs (updated)
-----

  
ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py
 e189d62 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 
0dcbea8 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
 ceee738 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
 94d9955 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 90c12ca 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_hdfs_client.py a165718 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 08eab25 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 34b639e 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py c8e7d27 
  ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_client.py 46cacf5 
  ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py e43f6dc 
  ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_service_check.py 
646f5db 
  ambari-server/src/test/python/stacks/utils/RMFTestCase.py ebb3cbc 

Diff: https://reviews.apache.org/r/47417/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi