> On máj. 27, 2016, 12:09 du, Daniel Gergely wrote: > >
Just a quiestion: if \n separated string is needed only for the UI, wouldnt it be better to handle it on the UI side? So UI can do the conversion, since it is not needed anywhere else. If it is also used somewhere else, then fine. - Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47949/#review135224 ----------------------------------------------------------- On máj. 27, 2016, 10:48 de, Swapan Shridhar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47949/ > ----------------------------------------------------------- > > (Updated máj. 27, 2016, 10:48 de) > > > Review request for Ambari, Alejandro Fernandez, Daniel Gergely, and Sumit > Mohanty. > > > Bugs: AMBARI-16923 > https://issues.apache.org/jira/browse/AMBARI-16923 > > > Repository: ambari > > > Description > ------- > > - We need to read 'capacity-schdeuler' : > 1. Firstly, from configurations where the configs can either be a > dictionary or single "\n" string. It will be there if there is a change done > to it as part of current invocation. If they are not there, then go ahead and > read: > 2. services for the configs where again it can either be a a dictionary or > single "\n" string. > > > - Removed stack_advisor.py 221-234 lines as they are no more valid as we dont > do calulation based on change to cache value now. > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > 8c5351f > ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py > 0066e1d > > Diff: https://reviews.apache.org/r/47949/diff/ > > > Testing > ------- > > - Python UT added. > - > - Python UT passes. > > > Thanks, > > Swapan Shridhar > >
