-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48273/#review136305
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
 (lines 74 - 78)
<https://reviews.apache.org/r/48273/#comment201328>

    You're uploading things to HDFS on Ranger start; but this will fail on any 
stack upgrade as HDFS is started after Ranger.



ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 (line 241)
<https://reviews.apache.org/r/48273/#comment201330>

    Rename to `retry_enabled` to match other propery naming conventions.



ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/setup_ranger_atlas.py
 (lines 31 - 33)
<https://reviews.apache.org/r/48273/#comment201332>

    Doesn't Ranger start before HDFS?


- Jonathan Hurley


On June 6, 2016, 11:26 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48273/
> -----------------------------------------------------------
> 
> (Updated June 6, 2016, 11:26 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Srimanth 
> Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17054
>     https://issues.apache.org/jira/browse/AMBARI-17054
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Patch contains changes to support Ranger Atlas Plugin from Ambari.
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  34d1a1a 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
>  1e9e7a7 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  a79a456 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/setup_ranger_atlas.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py
>  4c54214 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-env.xml
>  4db7f45 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/themes/theme_version_3.json
>  0f7b0c0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  8b669e8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
>  98cbc30 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-audit.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-plugin-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-policymgr-ssl.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-security.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 379c268 
> 
> Diff: https://reviews.apache.org/r/48273/diff/
> 
> 
> Testing
> -------
> 
> Verified : 
> 
> 1) Enable / disable actions for Ranger Atlas Plugin
> 2) Checked Ranger plugin comminication. 
> 3) Checked policy enforecements on Atlas based on Ranger's policies.
> 4) Verified stack advisor recommendations to chnange following properties : 
>     
> atlas.authorizer.impl=org.apache.ranger.authorization.atlas.authorizer.RangerAtlasAuthorizer
>     ranger-atlas-plugin-enabled=yes
> 5) Verified Ranger service creation (while enabling Ranger Atlas Plugin)
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Reply via email to