----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/#review136423 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java (line 161) <https://reviews.apache.org/r/48266/#comment201475> clusterProvisionWithBlueprintFinished might be a better naming as what this method checks is if the cluster provisioning that was initiated via Blueprint has finished or not. Also comment what the method does. ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java (lines 713 - 723) <https://reviews.apache.org/r/48266/#comment201480> Can't you juast pass down the type of the original topology request and check if that is '''TopologyRequest.Type.Provision''' ? - Sebastian Toader On June 7, 2016, 9:47 a.m., Daniel Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48266/ > ----------------------------------------------------------- > > (Updated June 7, 2016, 9:47 a.m.) > > > Review request for Ambari, Laszlo Puskas, Oliver Szabo, Robert Nettleton, > Sandor Magyari, Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-17053 > https://issues.apache.org/jira/browse/AMBARI-17053 > > > Repository: ambari > > > Description > ------- > > Add a log message to see when the cluster is ready to use (cluster creation > finishes). > > An event after each heartbeat. At that time cluster provision request is > checked if it is finished or not. In case of an ambari server restart, the > replayed requests are used to determine which one was the provision request. > I could not find a nice way to do it, but I could make a workaround. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java > c6036c2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java > 3feac55 > > ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java > 1079806 > > ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java > e3f5b49 > > ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java > fd8653c > > Diff: https://reviews.apache.org/r/48266/diff/ > > > Testing > ------- > > Still running locally... > > > Thanks, > > Daniel Gergely > >
