> On Июнь 7, 2016, 1:25 п.п., Robert Nettleton wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java, > > line 2623 > > <https://reviews.apache.org/r/48321/diff/2/?file=1408655#file1408655line2623> > > > > I'm a little unsure about this change. > > > > On the surface, this appears to be correct in terms of resolving the > > Exception, but my concern here is that we're not exactly sure what the > > value of this property should be when more than 1 Metrics Collector is > > deployed. > > > > I would recommend asking a Metrics expert about this. > > > > Basically, can the > > > > "timeline.metrics.service.webapp.address" property be used in a > > multi-collector environment? If so, is the value expected to be a > > comma-separated list of collectors?
You're right. timeline.metrics.service.webapp.address should contain single pair of hostname/ip + :port , that's true for AMS with multiple collectors and AMS HA - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48321/#review136457 ----------------------------------------------------------- On Июнь 7, 2016, 8:12 д.п., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48321/ > ----------------------------------------------------------- > > (Updated Июнь 7, 2016, 8:12 д.п.) > > > Review request for Ambari, Andrew Onischuk, Aravindan Vijayan, Robert > Nettleton, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-17082 > https://issues.apache.org/jira/browse/AMBARI-17082 > > > Repository: ambari > > > Description > ------- > > If blueprint contains 2 AMS collectors, Ambari server failed to start > METRICS_COLLECTOR with > > ERROR [pool-16-thread-1] TopologyManager:782 - > TopologyManager.ConfigureClusterTask: An exception occurred while attempting > to process cluster configs and set on cluster: > java.lang.IllegalArgumentException: Unable to update configuration property > 'timeline.metrics.service.webapp.address' with topology information. > Component 'METRICS_COLLECTOR' is mapped to an invalid number of hosts '2'. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > a0af813 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > 8b1a9a6 > > Diff: https://reviews.apache.org/r/48321/diff/ > > > Testing > ------- > > Unit tests passed > > > Thanks, > > Dmytro Sen > >
