> On jún. 13, 2016, 9:23 du, Sumit Mohanty wrote: > > Does this handle UI based cluster deployments? > > Probably there is no good way for UI based deplyments to know if a specific > > request is a cluster create request or not. > > > > What happens after cluster creation is over - does the code continue to > > handle Heartbeat processing completed event? > > Would it have been possible to create an event for Request-Completed and > > process that rather than Heartbeat processing completed?
This issue was only about blueprint deployment. UI based deployment is not tracked. If cluster creation is completed, event is still kept sending, however the subscribed method does nothing in this case. So it does not affect performance or does unnecessary calculations. I did not think about tracking request completition, because I felt that the minimum number of checks can be achieved by tracking only heartbeats. - Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/#review137384 ----------------------------------------------------------- On jún. 11, 2016, 6:43 de, Daniel Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48266/ > ----------------------------------------------------------- > > (Updated jún. 11, 2016, 6:43 de) > > > Review request for Ambari, Laszlo Puskas, Oliver Szabo, Robert Nettleton, > Sandor Magyari, Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-17053 > https://issues.apache.org/jira/browse/AMBARI-17053 > > > Repository: ambari > > > Description > ------- > > Add a log message to see when the cluster is ready to use (cluster creation > finishes). > > An event after each heartbeat. At that time cluster provision request is > checked if it is finished or not. In case of an ambari server restart, the > replayed requests are used to determine which one was the provision request. > I could not find a nice way to do it, but I could make a workaround. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java > c6036c2 > > ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java > 1079806 > > ambari-server/src/main/java/org/apache/ambari/server/events/HeartbeatProcessingFinishedEvent.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedState.java > 77419d8 > > ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedStateImpl.java > 324a397 > > ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java > e3f5b49 > > ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java > fd8653c > > Diff: https://reviews.apache.org/r/48266/diff/ > > > Testing > ------- > > Succeeded locally > > > Thanks, > > Daniel Gergely > >
