> On June 14, 2016, 1:03 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/RangerAuditDbCheck.java, > > line 35 > > <https://reviews.apache.org/r/48685/diff/1/?file=1418331#file1418331line35> > > > > Maybe make a new UpgradeCheckGroup for this - it's an information > > warning that something is happening during the upgrade. We might want to > > begin organizing these types of messages. Maybe > > UpgradeCheckGroup.INFORMATIONAL_WARNING
Updated in latest patch > On June 14, 2016, 1:03 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java, > > line 279 > > <https://reviews.apache.org/r/48685/diff/1/?file=1418330#file1418330line279> > > > > This is a bit confusing. Maybe revise as "Remove the Ranger Audit to > > Database Capability" Updated in latest patch > On June 14, 2016, 1:03 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java, > > lines 282-283 > > <https://reviews.apache.org/r/48685/diff/1/?file=1418330#file1418330line282> > > > > Hmmm - we're giving instructions here that the admin must run something > > after upgrade. Typically, that's not going to happen and they'll forget. > > What are the consequences? Can this be done by the python code? The instructions are for migration of audits from DB to Solr. If they dont do it, they will not see these logs on the Ranger UI, however they will still be available in the audit DB. This was designed not to be done as part of upgrade since the volume of audits are generally huge and it might block the entire upgrade. - Mugdha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48685/#review137496 ----------------------------------------------------------- On June 15, 2016, 5:13 a.m., Mugdha Varadkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48685/ > ----------------------------------------------------------- > > (Updated June 15, 2016, 5:13 a.m.) > > > Review request for Ambari, Gautam Borad, Jonathan Hurley, Srimanth Gunturi, > and Velmurugan Periasamy. > > > Bugs: AMBARI-17218 > https://issues.apache.org/jira/browse/AMBARI-17218 > > > Repository: ambari > > > Description > ------- > > Show Warning message before upgrade to stack 2.5 > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java > 850b58a > > ambari-server/src/main/java/org/apache/ambari/server/checks/RangerAuditDbCheck.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckGroup.java > 34d016e > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml > 464c444 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml > dd04b64 > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml > 27461e8 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml > ad1bc34 > > ambari-server/src/test/java/org/apache/ambari/server/checks/RangerAuditDbCheckTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/48685/diff/ > > > Testing > ------- > > Tested upgrade from 2.4 to 2.5 > > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m > -Djava.awt.headless=true > Running org.apache.ambari.server.checks.RangerAuditDbCheckTest > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.743 sec - > in org.apache.ambari.server.checks.RangerAuditDbCheckTest > > Results : > > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0 > > > Thanks, > > Mugdha Varadkar > >
