----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48494/ -----------------------------------------------------------
(Updated Июнь 15, 2016, 2 п.п.) Review request for Ambari, Robert Nettleton, Sebastian Toader, and Vitalyi Brodetskyi. Bugs: AMBARI-17146 https://issues.apache.org/jira/browse/AMBARI-17146 Repository: ambari Description ------- Implement config values trimming for deployment via blueprint as we do in UI trimProperty: function (property) { var displayType = Em.get(property, 'displayType'); var value = Em.get(property, 'value'); var name = Em.get(property, 'name'); var rez; switch (displayType) { case 'directories': case 'directory': rez = value.replace(/,/g, ' ').trim().split(/\s+/g).join(','); break; case 'host': rez = value.trim(); break; case 'password': break; default: if (name == 'javax.jdo.option.ConnectionURL' || name == 'oozie.service.JPAService.jdbc.url') { rez = value.trim(); } rez = (typeof value == 'string') ? value.replace(/(\s+$)/g, '') : value; } return ((rez == '') || (rez == undefined)) ? value : rez; }, Diffs (updated) ----- ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 9094698 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultTrimmingStrategy.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DeleteSpacesAtTheEndTrimmingStrategy.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DirectoriesTrimmingStrategy.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PasswordTrimmingStrategy.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PropertyValueTrimmingStrategyDefiner.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java ad8d4f9 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TrimmingStrategy.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java cda8fb8 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackTest.java e70af3e Diff: https://reviews.apache.org/r/48494/diff/ Testing ------- Unit tests and manual tests passed Thanks, Dmytro Sen