> On June 16, 2016, 6:15 p.m., Jayush Luniya wrote: > > This is causing unit test failures. Please take a look. > > > > ----------------------------------------------------------------------- > > Failed tests: > > FAIL: test_hook_default_conf_select > > (test_after_install.TestHookAfterInstall) > > ---------------------------------------------------------------------- > > Traceback (most recent call last): > > File > > "/Users/jluniya/release/trunk2/ambari/ambari-common/src/test/python/mock/mock.py", > > line 1199, in patched > > return func(*args, **keywargs) > > File > > "/Users/jluniya/release/trunk2/ambari/ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py", > > line 109, in test_hook_default_conf_select > > sudo = True,) > > File > > "/Users/jluniya/release/trunk2/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", > > line 278, in assertResourceCalled > > self.assertEquals(name, resource.name) > > AssertionError: Tuples differ: ('cp', '-R', '-p', '/etc/pig/c... != ('cp', > > '-R', '-p', '/etc/kafka... > > > > First differing element 3: > > /etc/pig/conf > > /etc/kafka/conf > > > > - ('cp', '-R', '-p', '/etc/pig/conf', '/etc/pig/conf.backup') > > ? ^^^ ^^^ > > > > + ('cp', '-R', '-p', '/etc/kafka/conf', '/etc/kafka/conf.backup') > > ? ^^^^^ ^^^^^ > > > > > > FAIL: test_hook_default_conf_select_suspended > > (test_after_install.TestHookAfterInstall) > > ---------------------------------------------------------------------- > > Traceback (most recent call last): > > File > > "/Users/jluniya/release/trunk2/ambari/ambari-common/src/test/python/mock/mock.py", > > line 1199, in patched > > return func(*args, **keywargs) > > File > > "/Users/jluniya/release/trunk2/ambari/ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py", > > line 695, in test_hook_default_conf_select_suspended > > sudo = True,) > > File > > "/Users/jluniya/release/trunk2/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", > > line 278, in assertResourceCalled > > self.assertEquals(name, resource.name) > > AssertionError: Tuples differ: ('cp', '-R', '-p', '/etc/pig/c... != ('cp', > > '-R', '-p', '/etc/kafka... > > > > First differing element 3: > > /etc/pig/conf > > /etc/kafka/conf > > > > - ('cp', '-R', '-p', '/etc/pig/conf', '/etc/pig/conf.backup') > > ? ^^^ ^^^ > > > > + ('cp', '-R', '-p', '/etc/kafka/conf', '/etc/kafka/conf.backup') > > ? ^^^^^ ^^^^^ > > > > > > FAIL: test_hook_default_conf_select_with_error > > (test_after_install.TestHookAfterInstall) > > ---------------------------------------------------------------------- > > Traceback (most recent call last): > > File > > "/Users/jluniya/release/trunk2/ambari/ambari-common/src/test/python/mock/mock.py", > > line 1199, in patched > > return func(*args, **keywargs) > > File > > "/Users/jluniya/release/trunk2/ambari/ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py", > > line 366, in test_hook_default_conf_select_with_error > > sudo = True,) > > File > > "/Users/jluniya/release/trunk2/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", > > line 278, in assertResourceCalled > > self.assertEquals(name, resource.name) > > AssertionError: Tuples differ: ('cp', '-R', '-p', '/etc/pig/c... != ('cp', > > '-R', '-p', '/etc/kafka... > > > > First differing element 3: > > /etc/pig/conf > > /etc/kafka/conf > > > > - ('cp', '-R', '-p', '/etc/pig/conf', '/etc/pig/conf.backup') > > ? ^^^ ^^^ > > > > + ('cp', '-R', '-p', '/etc/kafka/conf', '/etc/kafka/conf.backup') > > ? ^^^^^ ^^^^^ > > > > > > ---------------------------------------------------------------------- > > Total run:1062 > > Total errors:0 > > Total failures:3 > > ERROR > > INFO: AMBARI_SERVER_LIB is not set, using default /usr/lib/ambari-server > > INFO: Return code from stack upgrade command, retcode = 0 > > StackAdvisor implementation for stack HDP1, version 2.0.6 was not found > > Returning DefaultStackAdvisor implementation > > StackAdvisor implementation for stack XYZ, version 1.0.0 was loaded > > StackAdvisor implementation for stack XYZ, version 1.0.1 was loaded > > Returning XYZ101StackAdvisor implementation > > [INFO] > > ------------------------------------------------------------------------ > > [INFO] BUILD FAILURE > > [INFO] > > ------------------------------------------------------------------------ > > [INFO] Total time: 1:15.808s > > [INFO] Finished at: Thu Jun 16 09:56:48 PDT 2016 > > [INFO] Final Memory: 60M/837M > > [INFO] > > ------------------------------------------------------------------------
I don't have clues why my changes cause unit test failure, could you tell me how to run this specific unit test so that I can reproduce it ? Thanks - Jeff ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47941/#review138042 ----------------------------------------------------------- On June 15, 2016, 11:06 p.m., Jeff Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47941/ > ----------------------------------------------------------- > > (Updated June 15, 2016, 11:06 p.m.) > > > Review request for Ambari, Jayush Luniya and Sumit Mohanty. > > > Bugs: AMBARI-16920 > https://issues.apache.org/jira/browse/AMBARI-16920 > > > Repository: ambari > > > Description > ------- > > This a followup ticket for add spark2 stack definition. There's serveral > issues: > 1. Spark2 thrift server can not started due to miss of > spark-thrift-fairscheduler.xml > 2. Miss of add spark2 cache file in copy_barball.py > 3. Miss the role_commnad_order of spark2 > 4. conf_select is missign for spark2 > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py > 4eb0015 > > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py > 286df8d > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py > be99edd > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py > c2385df > ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json > f6011b0 > > Diff: https://reviews.apache.org/r/47941/diff/ > > > Testing > ------- > > Manually verified. > > > Thanks, > > Jeff Zhang > >