> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs, > > line 26 > > <https://reviews.apache.org/r/48487/diff/1/?file=1412307#file1412307line26> > > > > Where is the versions-table-wrap class defined? > > Wouldnt it cause the views/queues.js code to break?
versionPanel.hbs itself is a new file and class "versions-table-wrap" is used for styling and styles are defined in application.less. views/queues.js would not break since queues.js uses above as id and versionPanel uses as class name. - Akhil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48487/#review139036 ----------------------------------------------------------- On June 9, 2016, 12:05 p.m., Akhil PB wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48487/ > ----------------------------------------------------------- > > (Updated June 9, 2016, 12:05 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and > Sreenath Somarajapuram. > > > Bugs: AMBARI-17137 > https://issues.apache.org/jira/browse/AMBARI-17137 > > > Repository: ambari > > > Description > ------- > > Capacity Scheduler View - Node label to queue mappings and save integration > for all tabs > > > Diffs > ----- > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js > 7f7bc3b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js > bbf0cab > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js > 113ad13 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js > 7af45bb > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js > 1ee7a6b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js > 518b677 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js > 93f6645 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js > c0c56b6 > contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js > 3dfe363 > contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js > 45146ef > contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js > a32e02c > contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js > 7fef4be > contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less > 9952045 > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js > 17b279a > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs > 1eead4b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs > e54e14b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs > 55910ee > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs > ee9616b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs > b81474e > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs > aad16c2 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs > f11b786 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayRootLabel.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/labelCapacityBar.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs > 24f6938 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs > 759c0f3 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/saveConfigDialog.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs > f252005 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js > b2ae1d5 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js > 0dde62b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/views/queuesconf.js > 5cef8e5 > > Diff: https://reviews.apache.org/r/48487/diff/ > > > Testing > ------- > > Manual Unit Testing > > > Thanks, > > Akhil PB > >
