-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49128/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-17389
    https://issues.apache.org/jira/browse/AMBARI-17389


Repository: ambari


Description
-------

Change done in the way we read : 'yarn.nodemanager.resource.memory-mb' and 
'yarn.scheduler.minimum-allocation-mb' for calculating LLAP configs.

- Reads from:
    - configurations (if changed as part of current Stack Advisor invocation 
(output)), and services["changed-configurations"]
      is empty  -> Implies 1st invocation of SA, else
    - services['configurations'] (input) -> Subsequent invocations from UI.

- services["changed-configurations"] would be empty if Stack Advisor call is 
made from Blueprints (1st invocation). Subsequent
  Stack Advisor calls will have it non-empty. We do this because in subsequent 
invocations, even if Stack Advsior calculates this
  value (configurations), it is finally not recommended, making 'input' value 
to survive.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
8aa2f5f 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py fce1c1c 

Diff: https://reviews.apache.org/r/49128/diff/


Testing
-------

Updated Python UTs.


Thanks,

Swapan Shridhar

Reply via email to