> On June 29, 2016, 12:01 a.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py, > > line 277 > > <https://reviews.apache.org/r/49309/diff/1/?file=1431769#file1431769line277> > > > > Should assign a default value since can still be None.
@Alejandro Fernandez This has been already committed. I have attached the patch AMBARI-17462.1.patch on https://issues.apache.org/jira/browse/AMBARI-17462. Please review attached patch on Jira. Thanks > On June 29, 2016, 12:01 a.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py, > > line 279 > > <https://reviews.apache.org/r/49309/diff/1/?file=1431769#file1431769line279> > > > > Shouldn't access index 1 without first checking the length Same as above > On June 29, 2016, 12:01 a.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py, > > line 284 > > <https://reviews.apache.org/r/49309/diff/1/?file=1431769#file1431769line284> > > > > this is equivalent to just custom_log4j = has_logsearch Same as above - Mugdha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49309/#review139904 ----------------------------------------------------------- On June 28, 2016, 11:47 a.m., Mugdha Varadkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49309/ > ----------------------------------------------------------- > > (Updated June 28, 2016, 11:47 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Don Bosco Durai, Gautam > Borad, Oliver Szabo, Srimanth Gunturi, and Velmurugan Periasamy. > > > Bugs: AMBARI-17462 > https://issues.apache.org/jira/browse/AMBARI-17462 > > > Repository: ambari > > > Description > ------- > > From Ambari installation, install Log search client package with Ranger > Service for stack 2.5 onwards > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > c46309e > > ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py > ecc4f49 > > ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py > bab65dc > ambari-server/src/main/resources/common-services/RANGER/0.4.0/metainfo.xml > 40ad69f > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > 817d3f7 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py > f48720c > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > e1b5bc5 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/templates/ranger_solr_jass_conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-env.xml > eff0cd2 > ambari-server/src/main/resources/common-services/RANGER/0.6.0/metainfo.xml > adfb8ff > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > 789c5ba > ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py > 9b3c631 > ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-default.json > 53da262 > ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-secured.json > 14571bd > > Diff: https://reviews.apache.org/r/49309/diff/ > > > Testing > ------- > > Running tests for stack:2.5 service:RANGER > test_configure_default (test_ranger_admin.TestRangerAdmin) ... ok > test_configure_secured (test_ranger_admin.TestRangerAdmin) ... ok > test_start_default (test_ranger_admin.TestRangerAdmin) ... ok > test_start_secured (test_ranger_admin.TestRangerAdmin) ... ok > test_stop_default (test_ranger_admin.TestRangerAdmin) ... ok > test_configure_default (test_ranger_usersync.TestRangerUsersync) ... ok > test_configure_secured (test_ranger_usersync.TestRangerUsersync) ... ok > test_start_default (test_ranger_usersync.TestRangerUsersync) ... ok > test_stop_default (test_ranger_usersync.TestRangerUsersync) ... ok > test_configure_default (test_ranger_tagsync.TestRangerTagsync) ... ok > test_configure_secured (test_ranger_tagsync.TestRangerTagsync) ... ok > test_start_default (test_ranger_tagsync.TestRangerTagsync) ... ok > test_stop_default (test_ranger_tagsync.TestRangerTagsync) ... ok > > ---------------------------------------------------------------------- > Ran 13 tests in 0.330s > > OK > > > Thanks, > > Mugdha Varadkar > >
