----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49450/#review140166 -----------------------------------------------------------
Ship it! Ship It! - Ashwin Rajeev On June 30, 2016, 1:57 p.m., Nitiraj Rathore wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49450/ > ----------------------------------------------------------- > > (Updated June 30, 2016, 1:57 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-17501 > https://issues.apache.org/jira/browse/AMBARI-17501 > > > Repository: ambari > > > Description > ------- > > ported and resolved conflicts. also added timeout of 1 sec before fetching > the status of job in loop > > > Diffs > ----- > > contrib/views/hive-next/pom.xml d108095 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/Aggregator.java > 083423a > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/JobService.java > 53b91db > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/viewJobs/JobImpl.java > 17d585f > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/CSVParams.java > PRE-CREATION > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/TableDataReader.java > d7dba85 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/TableInput.java > 9c27b24 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadFromHdfsInput.java > 8214579 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java > e0bc083 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/DataParser.java > 0aec39f > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/IParser.java > dc0c552 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/ParseOptions.java > 53af85a > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/Parser.java > 2623c4c > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/RowIterator.java > 747e7ff > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/CSVIterator.java > c4abb99 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/CSVParser.java > daff342 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/commonscsv/CSVIterator.java > PRE-CREATION > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/commonscsv/CSVParser.java > PRE-CREATION > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/opencsv/OpenCSVIterator.java > PRE-CREATION > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/opencsv/OpenCSVParser.java > PRE-CREATION > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/InsertFromQueryInput.java > 22dec67 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/QueryGenerator.java > a9bc2b9 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/RowFormat.java > PRE-CREATION > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/TableInfo.java > 2b91d7b > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/upload-table.js > 6fa6cfd > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js > a00f0b4 > contrib/views/hive-next/src/main/resources/ui/hive-web/app/styles/app.scss > f0c9a4c > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/upload-table.hbs > 5e3a519 > > contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/CSVParserTest.java > fab1328 > > contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/DataParserCSVTest.java > 6b57228 > > contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/DataParserJSONTest.java > 1ea7ec2 > > contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/DataParserXMLTest.java > 2faf4e9 > > contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/OpenCSVParserTest.java > PRE-CREATION > > contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/OpenCSVTest.java > PRE-CREATION > > contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/QueryGeneratorTest.java > f549206 > > contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/TableDataReaderTest.java > d65cdb0 > > Diff: https://reviews.apache.org/r/49450/diff/ > > > Testing > ------- > > manual testing done. > > > Thanks, > > Nitiraj Rathore > >