----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49504/#review140332 -----------------------------------------------------------
Ship it! Ship It! - Dmytro Grinenko On July 1, 2016, 10:51 a.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49504/ > ----------------------------------------------------------- > > (Updated July 1, 2016, 10:51 a.m.) > > > Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Velmurugan > Periasamy. > > > Bugs: AMBARI-17514 > https://issues.apache.org/jira/browse/AMBARI-17514 > > > Repository: ambari > > > Description > ------- > > For ORACLE: > Case 1 > db_host=host:port:SID, example: db_host=localhost:1521:ORCL > connection_string = jdbc:oracle:thin:@db_host > Case 2 > db_host=host:port/ServiceName, example: db_host=localhost:1521/XE > connection_string = jdbc:oracle:thin:@//db_host > Adding message if user forgot to set jdbc using "ambari-server setup > --jdbc-db= --jdbc-driver=" > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > ba8d3b3 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > e35ea5f > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py > 133760b > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py > dce6576 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 6a3df08 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > 62d926e > > Diff: https://reviews.apache.org/r/49504/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
