On July 4, 2016, 6:58 p.m., Masahiro Tanaka wrote: > > What about existing clusters? We probably need to modify any existing ZK > > alerts with this using the UpgradeCatalog. > > Masahiro Tanaka wrote: > Thank you for reviewing. Which one should we change, > `UpgradeCatalog230.java`, or `UpgradeCatalog240.java`? > > Jonathan Hurley wrote: > Always the latest one for the release (or the branch). Since we're > readying the 2.4 release, then you can edit UpgadeCatalog240. If you > backported this to, say, the 2.2 branch (as an example), you'd edit > UpgradeCatalog220. > > Masahiro Tanaka wrote: > Thanks. I'll update UpgradeCatalog240 and UpgradeCatalog220
I don't think we would accept this into the 2.2 branch unless you were directed to do so. I recommend sticking with trunk and branch-2.4. - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/#review140707 ----------------------------------------------------------- On July 4, 2016, 3:01 p.m., Masahiro Tanaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48972/ > ----------------------------------------------------------- > > (Updated July 4, 2016, 3:01 p.m.) > > > Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole. > > > Bugs: AMBARI-17253 > https://issues.apache.org/jira/browse/AMBARI-17253 > > > Repository: ambari > > > Description > ------- > > There are too many WARNING in ZooKeeper log. > ``` > 2016-06-15 21:02:15,405 - WARN > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of > stream exception > EndOfStreamException: Unable to read additional data from client sessionid > 0x0, likely client has closed socket > at > org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228) > at > org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208) > at java.lang.Thread.run(Thread.java:745) > ``` > > It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port > to do monitoring. > We should use 'ruok' to monitor zookeepers. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 > ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/PortSource.java > d7279de > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/alerts.json > 469036a > > Diff: https://reviews.apache.org/r/48972/diff/ > > > Testing > ------- > > mvn clean test > > ``` > +1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > +1 tests included. The patch appears to include 1 new or modified test files. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in . > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console > This message is automatically generated. > ``` > > > Thanks, > > Masahiro Tanaka > >