> On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote: > > I'm curious if you can make this simply by only using the > > `commandParams/version` property when calculating what to do. Here's an > > example of the various values during normal commands, upgrades, and > > downgrades. `version` seems to always be what you want, no? > > > > ``` > > NORMAL COMMANDS > > hostLevelParams > > stack_name = HDP > > stack_version = 2.3 > > current_version = 2.3.4.0-1234 > > > > commandParams > > version = 2.3.4.0-1234 > > > > > > UPGRADE > > hostLevelParams > > stack_name = HDP > > stack_version = 2.3 > > current_version = 2.3.4.0-1234 > > > > commandParams > > original_stack = 2.3 > > target_stack = 2.5 > > upgrade_direction = UPGRADE > > version = 2.5.0.0-9999 > > > > > > DOWNGRADE > > hostLevelParams > > stack_name = HDP > > stack_version = 2.5 > > current_version = 2.3.4.0-1234 > > > > commandParams > > original_stack = 2.3 > > target_stack = 2.5 > > upgrade_direction = DOWNGRADE > > version = 2.3.4.0-1234 > > downgrade_from_version = 2.5.0.0-9999 > > ``` > > Mugdha Varadkar wrote: > Thanks Jonathan Hurley. Actually this was done by taking reference from > similar code from > Ambari.(https://github.com/apache/ambari/commit/63f8d74f806aa55fcbb4e51b2c84a3fd0146c062#diff-a9a4cbc8111690ebc76b1e83491d2dba) > > @Jayush Luniya, can we use version in NORMAL COMMANDS/UPGRADE/DOWNGRADE > scenarios? > > Jonathan Hurley wrote: > Actually, an even better option is this: > > ``` > # determine which version to use for checking stack features; version is > the most accurate but > # may not always be available (especially on first install of the cluster) > version_for_stack_feature_checks = version if not None else > stack_version_unformatted > ``` > > It's possible that on initial install, `version` isn't defined since we > haven't calculated it yet. So, the above defaults to the stack version in > that case. Now, version covers all 3 of your scenarios.
Updated in latest patch > On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py, > > line 60 > > <https://reviews.apache.org/r/49987/diff/1/?file=1443235#file1443235line60> > > > > No need for `stack_version_formatted and` here ... just call > > `check_stack_feature` directly. > > Mugdha Varadkar wrote: > @Jonathan Hurley, am directly using check_stack_feature here because even > if we pass version as ---> 2.3.4.0-1234, the code has format flag as true, > which calls format_stack_version() function which can be used for comparision. > "compare_versions(stack_version, min_version, format = True) < 0" > > Also I have added the check for "version" in this way "if > upgrade_direction == Direction.DOWNGRADE and version" > > Jonathan Hurley wrote: > My point was that the code was originally: > `foo and check_stack_feature(feature, foo) ` > > You don't need the "foo and" part since the check_stack_feature is > checking it for None anyway. Updated in latest patch > On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py, > > line 61 > > <https://reviews.apache.org/r/49987/diff/1/?file=1443236#file1443236line61> > > > > No need for `stack_version_formatted and` here ... just call > > `check_stack_feature` directly. > > Mugdha Varadkar wrote: > Same as above Updated in latest patch > On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py, > > line 58 > > <https://reviews.apache.org/r/49987/diff/1/?file=1443238#file1443238line58> > > > > No need for `stack_version_formatted and` here ... just call > > `check_stack_feature` directly. > > Mugdha Varadkar wrote: > Same as above Updated in latest patch > On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py, > > line 57 > > <https://reviews.apache.org/r/49987/diff/1/?file=1443239#file1443239line57> > > > > No need for `stack_version_formatted and` here ... just call > > `check_stack_feature` directly. > > Mugdha Varadkar wrote: > Same as above Updated in latest patch > On July 13, 2016, 2:33 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py, > > line 47 > > <https://reviews.apache.org/r/49987/diff/1/?file=1443241#file1443241line47> > > > > No need for `stack_version_formatted and` here ... just call > > `check_stack_feature` directly. > > Mugdha Varadkar wrote: > Same as above Updated in latest patch - Mugdha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49987/#review142063 ----------------------------------------------------------- On July 14, 2016, 2:23 p.m., Mugdha Varadkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49987/ > ----------------------------------------------------------- > > (Updated July 14, 2016, 2:23 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan > Hurley, Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy. > > > Bugs: AMBARI-17687 > https://issues.apache.org/jira/browse/AMBARI-17687 > > > Repository: ambari > > > Description > ------- > > Scenario: > 1. install ranger with stack 2.4 and ambari-2.4.0 > 2. register the version of stack 2.5 > 3. perform the upgrade > at the step where it where zookeepers are upgraded , just downgraded. > 4. downgrade was successful > 5. check ranger service status , it was down > try to restart the ranger but ranger startup is failing > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py > 0df8270 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > 145c216 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > f24bd83 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 63a1100 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > f47eee4 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > 7e0477f > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > fad4b9b > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py > dfcad32 > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py > 5941ca1 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > 44a0446 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml > 4c122e9 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml > bbd0fe4 > > Diff: https://reviews.apache.org/r/49987/diff/ > > > Testing > ------- > > Test Ranger Downgrade from stack 2.5 to 2.4 > > > Thanks, > > Mugdha Varadkar > >
