> On July 28, 2016, 4:16 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py, > > line 74 > > <https://reviews.apache.org/r/50565/diff/1/?file=1456532#file1456532line74> > > > > I don't think you need the `upgrade_type is not None` since you have an > > equality check right after it.
Updated it latest patch > On July 28, 2016, 4:16 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py, > > line 66 > > <https://reviews.apache.org/r/50565/diff/1/?file=1456531#file1456531line66> > > > > I don't think you need the `upgrade_type is not None` since you have an > > equality check right after it. Updated it latest patch > On July 28, 2016, 4:16 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py, > > lines 67-68 > > <https://reviews.apache.org/r/50565/diff/1/?file=1456531#file1456531line67> > > > > I'd rather see a specific check in the stack feature stuff for this; > > it's not clear what combination of stack features affect this. Yes it is specific for stack 2.2 only - Mugdha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50565/#review143950 ----------------------------------------------------------- On July 29, 2016, 12:16 p.m., Mugdha Varadkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50565/ > ----------------------------------------------------------- > > (Updated July 29, 2016, 12:16 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan > Hurley, Nate Cole, Srimanth Gunturi, and Velmurugan Periasamy. > > > Bugs: AMBARI-17945 > https://issues.apache.org/jira/browse/AMBARI-17945 > > > Repository: ambari > > > Description > ------- > > As part of changes done in this AMBARI-17840, following changes are required > to handle EU scenario : > > 1] need to change the owner/mode of stop script and > 2] create symbolic link if it does not exists. > > > This patch handles the following upgrade scenarios: > 1) ranger admin from 2.2.x to 2.2.y > 2) ranger usersync from 2.2.x to 2.3, 2.4 > 3) ranger kms from 2.3 to 2.3.x, 2.4, 2.5 > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py > c0534f3 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py > 5ce0617 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py > cbdcc8c > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py > 55c0486 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py > 4888aa6 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml > 95310d5 > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml > 6e7e272 > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml > b368db3 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml > 9eb4a44 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml > e67b82c > > Diff: https://reviews.apache.org/r/50565/diff/ > > > Testing > ------- > > Tested EU from > 2.2 to 2.2 > 2.2 to 2.4 > 2.4 to 2.5 > > > Thanks, > > Mugdha Varadkar > >
