> On Aug. 2, 2016, 1:49 p.m., Robert Levas wrote: > > ambari-funtest/pom.xml, lines 334-337 > > <https://reviews.apache.org/r/50711/diff/1/?file=1460643#file1460643line334> > > > > Can you remove other instances of commons-httpclient in the Ambari > > server pom.xml files > > > > - ambari > > - ambari-project > > - ambari-sever > > > > There is a log-search one too, but if that requires a bunch of > > refactoring, lets do that in another patch. > > Nahappan Somasundaram wrote: > This patch already has the fixes for ambari-project, ambari-server and > log-search. The top level ambari POM does not have any reference to > commons-httpclient.
ok.. I guess I misread my search... sorry about that. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50711/#review144509 ----------------------------------------------------------- On Aug. 2, 2016, 12:25 p.m., Nahappan Somasundaram wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50711/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2016, 12:25 p.m.) > > > Review request for Ambari, Mahadev Konar, Robert Levas, Sumit Mohanty, and > Sid Wagle. > > > Bugs: AMBARI-17992 > https://issues.apache.org/jira/browse/AMBARI-17992 > > > Repository: ambari > > > Description > ------- > > AMBARI-17992: Ambari should remove all references to commons-httpclient > > > Diffs > ----- > > ambari-funtest/pom.xml 28225c26ed71ec80e2f3f315981c965bf3f7da33 > > ambari-funtest/src/test/java/org/apache/ambari/funtest/server/AmbariHttpWebRequest.java > 4a91176ce88db24ccbefd13e3fd636318e909fe3 > > ambari-funtest/src/test/java/org/apache/ambari/funtest/server/tests/DeleteServiceTest.java > 747ae95a87f79d91fb5b0bc738121dd8affcd563 > > ambari-funtest/src/test/java/org/apache/ambari/funtest/server/tests/GetStacksTest.java > 4f316b500f273356aa64e12adeb3893c7aa37a7e > > ambari-funtest/src/test/java/org/apache/ambari/funtest/server/tests/RoleBasedAccessControlBasicTest.java > 947cfd064f28c2b0152f9cd98cd7248e09f9ce39 > > ambari-funtest/src/test/java/org/apache/ambari/funtest/server/tests/ServerTestBase.java > 7b9600f82ec540b417bcb956b245dc09578de5b6 > > ambari-funtest/src/test/java/org/apache/ambari/funtest/server/utils/RestApiUtils.java > 65e1f7c76cbd5ed6fe9836005b27d251c8b10ac2 > ambari-logsearch/ambari-logsearch-portal/pom.xml > 479420f9cbbec5a23007e1bea29cb205dbb6527b > ambari-project/pom.xml 617e7aad394b94c631164bd66e299599e15e9c99 > ambari-server/pom.xml 930aef06b77135055150fcfab450ba603d94022a > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/MetricsRequestHelper.java > 388de15d65da05803a90f61f21cb11e106ef6ac2 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/LoggingServiceTest.java > 6bf8a8a155279c7ec7a8082a644ccd5acba04b26 > > ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java > c32e517e46ba8e3fda2fb7229ad6fb21c207a9b6 > > ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/MetricsRequestHelperTest.java > 52792b189e5cb6a072117d2863f4a5c95d751d96 > > Diff: https://reviews.apache.org/r/50711/diff/ > > > Testing > ------- > > ** 1. mvn clean install -DskipSurefireTests -DskipPythonTests ** > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [7.960s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.040s] > [INFO] Ambari Web ........................................ SUCCESS [31.845s] > [INFO] Ambari Views ...................................... SUCCESS [1.005s] > [INFO] Ambari Admin View ................................. SUCCESS [8.278s] > [INFO] ambari-metrics .................................... SUCCESS [0.703s] > [INFO] Ambari Metrics Common ............................. SUCCESS [3.815s] > [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [2.139s] > [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [1.309s] > [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [1.366s] > [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [3.550s] > [INFO] Ambari Metrics Storm Sink (Legacy) ................ SUCCESS [1.523s] > [INFO] Ambari Metrics Collector .......................... SUCCESS [11.525s] > [INFO] Ambari Metrics Monitor ............................ SUCCESS [2.372s] > [INFO] Ambari Metrics Grafana ............................ SUCCESS [1.261s] > [INFO] Ambari Metrics Assembly ........................... SUCCESS [1:17.156s] > [INFO] Ambari Server ..................................... SUCCESS [2:31.213s] > [INFO] Ambari Functional Tests ........................... SUCCESS [1.065s] > [INFO] Ambari Agent ...................................... SUCCESS [24.951s] > [INFO] Ambari Client ..................................... SUCCESS [0.051s] > [INFO] Ambari Python Client .............................. SUCCESS [1.070s] > [INFO] Ambari Groovy Client .............................. SUCCESS [2.110s] > [INFO] Ambari Shell ...................................... SUCCESS [0.039s] > [INFO] Ambari Python Shell ............................... SUCCESS [0.661s] > [INFO] Ambari Groovy Shell ............................... SUCCESS [0.812s] > [INFO] ambari-logsearch .................................. SUCCESS [0.253s] > [INFO] Ambari Logsearch Appender ......................... SUCCESS [0.316s] > [INFO] Ambari Logsearch Solr Client ...................... SUCCESS [1.113s] > [INFO] Ambari Logsearch Portal ........................... SUCCESS [5.967s] > [INFO] Ambari Logsearch Log Feeder ....................... SUCCESS [3.795s] > [INFO] Ambari Logsearch Assembly ......................... SUCCESS [0.076s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 5:51.575s > [INFO] Finished at: Tue Aug 02 09:17:02 PDT 2016 > [INFO] Final Memory: 304M/1212M > [INFO] > ------------------------------------------------------------------------ > > ** 2. mvn test ** > > *[Awaiting results. Also submitted a Jenkins patch. Will update this section > after local Unit Tests run is complete.]* > > > Thanks, > > Nahappan Somasundaram > >
