> On Aug. 3, 2016, 6:20 p.m., Aravindan Vijayan wrote: > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsAggregatorSink.java, > > line 37 > > <https://reviews.apache.org/r/50666/diff/3/?file=1459427#file1459427line37> > > > > Do the sink interface APIs need to take in a "tableName" ? Shouldn't > > the sink inteface just take in the data to be written, and decide what to > > do with the data in the implementation? > > Jameel Mohamed wrote: > Reason for this is by just giving the data interface will not know what > level of aggregates were performed. like minuter, hour or day.. So this is > required.
That should be passed in as a "Precision" parameter rather than a table name. Please take a look at the org.apache.hadoop.metrics2.sink.timeline.Precision. Or, that information can either be calculated at the Sink side by looking at the data. - Aravindan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50666/#review144637 ----------------------------------------------------------- On Aug. 1, 2016, 10:11 p.m., Jameel Mohamed wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50666/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2016, 10:11 p.m.) > > > Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-10145 > https://issues.apache.org/jira/browse/AMBARI-10145 > > > Repository: ambari > > > Description > ------- > > Added new Interface to drain aggregated metrics to external storage. Added > unit test and sample implementation > (TimelineMetricsAggregatorMemorySink.java) to store metrics in memory. > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java > dfd730d > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java > e82d65a > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsAggregatorSink.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessorTest.java > 0ea668a > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsAggregatorMemorySink.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/50666/diff/ > > > Testing > ------- > > Manually tested. > > > Added unit test. > > > mvn clean test > > > Thanks, > > Jameel Mohamed > >
