----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50047/#review144670 -----------------------------------------------------------
Ship it! Ship It! - Robert Levas On Aug. 3, 2016, 4:47 p.m., Anita Jebaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50047/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2016, 4:47 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, Nate > Cole, Robert Levas, and Sriharsha Chintalapani. > > > Bugs: AMBARI-17694 > https://issues.apache.org/jira/browse/AMBARI-17694 > > > Repository: ambari > > > Description > ------- > > When kerberos is enabled, the protocol for listeners in > /etc/kafka/conf/server.properties is updated from PLAINTEXT to PLAINTEXTSASL, > even though the Ambari UI shows otherwise > > > The patch was reverted due to a conflict, Based on Robert's comment there are > two versions of kerberos.json, > > …/stacks/HDP/2.5/services/KAFKA/kerberos.json > …/resources/common-services/KAFKA/0.9.0/kerberos.json > > The new version …/stacks/HDP/2.5/services/KAFKA/kerberos.json (AMBARI-17902) > has been added after the patch was committed for this review. I have included > the changes in the updated patch. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java > 66be3bf > ambari-server/src/main/resources/common-services/KAFKA/0.10.0/kerberos.json > e1e6461 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py > ac7b0ae > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json > 2b1c01b > > ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelperTest.java > ee2a671 > > Diff: https://reviews.apache.org/r/50047/diff/ > > > Testing > ------- > > Added 1 new test case, > Ran mvn test > Tested in Ambari UI, by enabling kerberos, listeners protocol is updated and > kafka started successfully > > > Thanks, > > Anita Jebaraj > >