----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50965/#review145407 -----------------------------------------------------------
Ship it! Looks good, very useful refactoring. Please consider a few suggestions for naming. - Alexander Denissov On Aug. 10, 2016, 8:30 p.m., Lav Jain wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50965/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2016, 8:30 p.m.) > > > Review request for Ambari, Alexander Denissov and Matt. > > > Bugs: AMBARI-18110 > https://issues.apache.org/jira/browse/AMBARI-18110 > > > Repository: ambari > > > Description > ------- > > Ambari build jobs are not running the unit tests for HAWQ. > HAWQ (and PXF) unit tests in the new common-services directory under test is > being ignored during mvn's test phase. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py > 529c492 > > ambari-server/src/test/python/common-services/HAWQ/test_alert_component_status.py > b2e1d4d > > ambari-server/src/test/python/common-services/HAWQ/test_alert_segment_registration_status.py > 4066e29 > > ambari-server/src/test/python/common-services/HAWQ/test_alert_sync_status.py > a44cad1 > ambari-server/src/test/python/common-services/HAWQ/test_hawqcommon.py > PRE-CREATION > ambari-server/src/test/python/common-services/HAWQ/test_hawqmaster.py > 62d54cf > ambari-server/src/test/python/common-services/HAWQ/test_hawqsegment.py > 48203ca > ambari-server/src/test/python/common-services/HAWQ/test_hawqstandby.py > 8674549 > ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py > e0f1c43 > ambari-server/src/test/python/common-services/PXF/test_alerts_api_status.py > ee187e2 > ambari-server/src/test/python/common-services/PXF/test_service_advisor.py > 8b2a4ba > ambari-server/src/test/python/unitTests.py b010804 > > Diff: https://reviews.apache.org/r/50965/diff/ > > > Testing > ------- > > ``` > Running tests for stack:None service:HAWQ > test_hawq_master_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_segment_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_hawq_standby_critical > (test_alert_component_status.TestAlertComponentStatus) ... ok > test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_missing_configs (test_alert_component_status.TestAlertComponentStatus) > ... ok > test_exception_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No > handlers could be found for logger "ambari_alerts" > ok > test_missing_configs > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_slave_file > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_successful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_empty_db_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_unsuccessful_registration_status_plural > (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok > test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... > ok > test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok > test_configure_default (test_hawqmaster.TestHawqMaster) ... ok > test_install_default (test_hawqmaster.TestHawqMaster) ... ok > test_remove_hawq_standby (test_hawqmaster.TestHawqMaster) > Run custom command Remove HAWQ Standby ... > /Users/ljain/dev/pivotal/ambari/ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts > 2016-08-10 13:20:33,060 - Removing HAWQ Standby Master ... > ok > test_resync_hawq_standby (test_hawqmaster.TestHawqMaster) > Run custom command Resync HAWQ Standby ... 2016-08-10 13:20:33,063 - HAWQ > Standby Master Re-Sync started in fast mode... > ok > test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster) > Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not > Kerberized ... 2016-08-10 13:20:33,067 - Executing HAWQ Check ... > ok > test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster) > Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, > Kerberized ... 2016-08-10 13:20:33,074 - Executing HAWQ Check ... > ok > test_run_hawq_check_case11 (test_hawqmaster.TestHawqMaster) > Running HAWQ Check Case 11: HDFS-HA, YARN Resource Management YARN_HA, Not > Kerberized ... 2016-08-10 13:20:33,081 - Executing HAWQ Check ... > ok > test_run_hawq_check_case12 (test_hawqmaster.TestHawqMaster) > Running HAWQ Check Case 12: HDFS-HA, YARN Resource Management YARN_HA, > Kerberized ... 2016-08-10 13:20:33,087 - Executing HAWQ Check ... > ok > test_run_hawq_check_case2 (test_hawqmaster.TestHawqMaster) > Running HAWQ Check Case 2: Non HDFS-HA, Standalone Resource Management, > Kerberized ... 2016-08-10 13:20:33,093 - Executing HAWQ Check ... > ok > test_run_hawq_check_case3 (test_hawqmaster.TestHawqMaster) > Running HAWQ Check Case 3: Non HDFS-HA, YARN Resource Management Non YARN_HA, > Not Kerberized ... 2016-08-10 13:20:33,099 - Executing HAWQ Check ... > ok > test_run_hawq_check_case4 (test_hawqmaster.TestHawqMaster) > Running HAWQ Check Case 4: Non HDFS-HA, YARN Resource Management Non YARN_HA, > Kerberized ... 2016-08-10 13:20:33,106 - Executing HAWQ Check ... > ok > test_run_hawq_check_case5 (test_hawqmaster.TestHawqMaster) > Running HAWQ Check Case 5: Non HDFS-HA, YARN Resource Management YARN_HA, Not > Kerberized ... 2016-08-10 13:20:33,112 - Executing HAWQ Check ... > ok > test_run_hawq_check_case6 (test_hawqmaster.TestHawqMaster) > Running HAWQ Check Case 6: Non HDFS-HA, YARN Resource Management YARN_HA, > Kerberized ... 2016-08-10 13:20:33,119 - Executing HAWQ Check ... > ok > test_run_hawq_check_case7 (test_hawqmaster.TestHawqMaster) > Running HAWQ Check Case 7: HDFS-HA, Standalone Resource Management, Not > Kerberized ... 2016-08-10 13:20:33,125 - Executing HAWQ Check ... > ok > test_run_hawq_check_case8 (test_hawqmaster.TestHawqMaster) > Running HAWQ Check Case 8: HDFS-HA, Standalone Resource Management, > Kerberized ... 2016-08-10 13:20:33,131 - Executing HAWQ Check ... > ok > test_run_hawq_check_case9 (test_hawqmaster.TestHawqMaster) > Running HAWQ Check Case 9: HDFS-HA, YARN Resource Management Non YARN_HA, Not > Kerberized ... 2016-08-10 13:20:33,138 - Executing HAWQ Check ... > ok > test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-08-10 > 13:20:33,146 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys > is either set to false or is not available in hawq-env.xml > ok > test_stop_cluster_immediate (test_hawqmaster.TestHawqMaster) > Run Stop HAWQ Cluster Immediate Mode ... ok > test_stop_default (test_hawqmaster.TestHawqMaster) > Run Stop HAWQMASTER ... ok > test_configure_default (test_hawqsegment.TestHawqSegment) ... ok > test_install_default (test_hawqsegment.TestHawqSegment) ... ok > test_start_default (test_hawqsegment.TestHawqSegment) ... ok > test_stop_default (test_hawqsegment.TestHawqSegment) ... ok > test_activate_hawq_standby (test_hawqstandby.TestHawqStandby) > Test Activate HAWQ Standby Command ... 2016-08-10 13:20:33,177 - Activating > HAWQ standby... > ok > test_configure_default (test_hawqstandby.TestHawqStandby) ... ok > test_install_default (test_hawqstandby.TestHawqStandby) ... ok > test_start_default (test_hawqstandby.TestHawqStandby) ... ok > test_stop_default (test_hawqstandby.TestHawqStandby) ... ok > test_createComponentLayoutRecommendations_hawq_1_Host > (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok > test_createComponentLayoutRecommendations_hawq_3_Hosts > (test_service_advisor.TestHAWQ200ServiceAdvisor) > Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed > (test_service_advisor.TestHAWQ200ServiceAdvisor) > Test that HAWQSEGMENT does not get recommended during Add Service Wizard, > when HAWQ has already been installed ... ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed > (test_service_advisor.TestHAWQ200ServiceAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, > when HAWQ is selected for installation ... ok > test_createComponentLayoutRecommendations_hawqsegment_cluster_install > (test_service_advisor.TestHAWQ200ServiceAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Cluster Install > Wizard, when HAWQ is selected for installation ... ok > test_createComponentLayoutRecommendations_no_hawq_3_Hosts > (test_service_advisor.TestHAWQ200ServiceAdvisor) > Test no failures when there are no HAWQ components ... ok > test_getComponentLayoutValidations_hawq_3_Hosts > (test_service_advisor.TestHAWQ200ServiceAdvisor) > Test layout validations for HAWQ components on a 3-node cluster ... ok > test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode > (test_service_advisor.TestHAWQ200ServiceAdvisor) > Test validation warning for HAWQ segment not colocated with DATANODE ... ok > test_getComponentLayoutValidations_nohawq_3_Hosts > (test_service_advisor.TestHAWQ200ServiceAdvisor) > Test no failures when there are no HAWQ components on a 3-node cluster ... ok > test_getHostsForMasterComponent > (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok > test_getServiceConfigurationRecommendations > (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok > test_validateHAWQHdfsClientConfigurations > (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok > test_validateHAWQSiteConfigurations > (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok > test_validateHDFSSiteConfigurations > (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok > test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok > > ---------------------------------------------------------------------- > Ran 65 tests in 0.241s > > OK > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > ServiceAdvisor implementation for service HAWQ was loaded > Running tests for stack:None service:PXF > test_execute (test_alerts_api_status.TestAlertsApiStatus) ... No handlers > could be found for logger "ambari_alerts" > ok > test_get_pxf_protocol_version (test_alerts_api_status.TestAlertsApiStatus) > ... ok > test_configure_default (test_pxf.TestPxf) ... ok > test_install_default (test_pxf.TestPxf) ... ok > test_start_default (test_pxf.TestPxf) ... ok > test_status_default (test_pxf.TestPxf) ... ok > test_stop_default (test_pxf.TestPxf) ... ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed > (test_service_advisor.TestPXF300ServiceAdvisor) > Test that PXF does not get recommended during Add Service Wizard, when PXF > has already been installed ... ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed > (test_service_advisor.TestPXF300ServiceAdvisor) > Test that PXF gets recommended correctly during Add Service Wizard, when PXF > is selected for installation ... ok > test_createComponentLayoutRecommendations_pxf_cluster_install > (test_service_advisor.TestPXF300ServiceAdvisor) > Test that PXF gets recommended correctly during Cluster Install Wizard, when > PXF is selected for installation ... ok > test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn > (test_service_advisor.TestPXF300ServiceAdvisor) > Test NO warning is generated when PXF is co-located with NAMENODE and > DATANODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_dn > (test_service_advisor.TestPXF300ServiceAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE or > DATANODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_nn > (test_service_advisor.TestPXF300ServiceAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn > (test_service_advisor.TestPXF300ServiceAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE or > DATANODE ... ok > test_getConfigurationsValidationItems > (test_service_advisor.TestPXF300ServiceAdvisor) ... ok > test_getServiceConfigurationRecommendations > (test_service_advisor.TestPXF300ServiceAdvisor) ... ok > > ---------------------------------------------------------------------- > Ran 16 tests in 0.038s > > OK > ServiceAdvisor implementation for service PXF was loaded > ServiceAdvisor implementation for service PXF was loaded > ServiceAdvisor implementation for service PXF was loaded > ``` > ``` > Total run:1115 > Total errors:0 > Total failures:0 > OK > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 01:01 min > [INFO] Finished at: 2016-08-10T13:20:41-07:00 > [INFO] Final Memory: 81M/1275M > [INFO] > ------------------------------------------------------------------------ > ``` > > > Thanks, > > Lav Jain > >