----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50995/#review146042 -----------------------------------------------------------
Can we have this tested on a cluster with no metrics.proerties file? - Aravindan Vijayan On Aug. 16, 2016, 11:23 p.m., Li-Wei Tseng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50995/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2016, 11:23 p.m.) > > > Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and > Yusaku Sako. > > > Bugs: AMBARI-17591 > https://issues.apache.org/jira/browse/AMBARI-17591 > > > Repository: ambari > > > Description > ------- > > Created metrics service which has a JVM metrics source and a sink. The JVM > metrics source collect JVM metrics and pass it to the sink which then publish > the metrics to AMS > > > Diffs > ----- > > ambari-server/conf/unix/metrics.properties PRE-CREATION > ambari-server/pom.xml e999d03 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > a6d8d6a > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > 2bd7eff > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ambari-server.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/50995/diff/ > > > Testing > ------- > > Manually tested it. > > > Thanks, > > Li-Wei Tseng > >
