> On Aug. 26, 2016, 2 p.m., Di Li wrote: > > Ship It!
Thanks Di. Could you please help me push this to trunk? - Amruta ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51441/#review146959 ----------------------------------------------------------- On Aug. 25, 2016, 11:29 p.m., Amruta Borkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51441/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2016, 11:29 p.m.) > > > Review request for Ambari, Di Li and Robert Nettleton. > > > Bugs: AMBARI-18179 > https://issues.apache.org/jira/browse/AMBARI-18179 > > > Repository: ambari > > > Description > ------- > > The patch validates component dependency for NN when HA is enabled cluster. > Observed that when a blueprint is deployed to create NN HA enabled cluster > without ZKFC compoent, installation goes through but HDFS service check > fails, giving error for missing ZKFC component. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java > dbf736f > > ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java > a5acc42 > > Diff: https://reviews.apache.org/r/51441/diff/ > > > Testing > ------- > > Added and modified test cases. Performed manual testing and blueprint was not > accepted when ZKFC was missing. > > > Thanks, > > Amruta Borkar > >