----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51725/#review148329 -----------------------------------------------------------
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/params_linux.py (line 49) <https://reviews.apache.org/r/51725/#comment215804> Is this necessary? contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/service_check.py (line 32) <https://reviews.apache.org/r/51725/#comment215805> Seems unnecessary, `HdfsResource` is used from `params` contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/service_check.py (line 45) <https://reviews.apache.org/r/51725/#comment215803> * Indent by 2 spaces, not 4 * Would be nice to extract `/user/RevoShare` to a variable in `params` - Attila Doroszlai On Sept. 9, 2016, 8:16 a.m., Balázs Bence Sári wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51725/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2016, 8:16 a.m.) > > > Review request for Ambari, Attila Doroszlai, Jayush Luniya, Oliver Szabo, > Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-18338 > https://issues.apache.org/jira/browse/AMBARI-18338 > > > Repository: ambari > > > Description > ------- > > - Added kerberos json to make sure the client can use the smokeuser and hdfs > keytabs. > - Added the creation of /user/RevoShare hdfs directory to the service check > (with hdfs user/principal) > - Extended stack support to HDP 2.4 and 2.5 > > > Diffs > ----- > > > contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/kerberos.json > PRE-CREATION > > contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/params_linux.py > d72c42e > > contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/service_check.py > 8a425ca > > Diff: https://reviews.apache.org/r/51725/diff/ > > > Testing > ------- > > Manually tested the installation and kerberization of MSFT-R via UI and > blueprints on 1-8 node clusters. > > > Thanks, > > Balázs Bence Sári > >
