> On Sept. 9, 2016, 9:16 p.m., Alejandro Fernandez wrote: > > ambari-web/app/controllers/wizard/step4_controller.js, line 37 > > <https://reviews.apache.org/r/51744/diff/1/?file=1494647#file1494647line37> > > > > -1 Why are we requiring HDP stacks to forcibly install SmartSense? > > This feels like a hidden tactic. Any user that wants to install > > SmartSense will add it, just as they do other components; plus, there's > > already a dialog box warning if the user doesn't select it. > > > > Devs, Sandbox, etc., don't need it.
UI shouldn't have knowledge about SmartSense. Instead, consider moving this to a stack config that is specific to this service. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51744/#review148373 ----------------------------------------------------------- On Sept. 8, 2016, 8:09 p.m., Vivek Ratnavel Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51744/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2016, 8:09 p.m.) > > > Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako. > > > Bugs: AMBARI-18346 > https://issues.apache.org/jira/browse/AMBARI-18346 > > > Repository: ambari > > > Description > ------- > > Perform a UI hack to force selection of SmartSense for HDP stacks (the user > cannot deselect). > > > Diffs > ----- > > ambari-web/app/controllers/wizard/step4_controller.js 04e6784 > ambari-web/app/mappers/stack_service_mapper.js c800e83 > ambari-web/app/models/stack_service.js 9cf9d49 > ambari-web/app/templates/wizard/step4.hbs c62d369 > > Diff: https://reviews.apache.org/r/51744/diff/ > > > Testing > ------- > > Verified manually. > Ambari-web unit test pass. > 29244 tests complete (26 seconds) > 154 tests pending > > > Thanks, > > Vivek Ratnavel Subramanian > >
