----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51813/#review148533 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py (line 42) <https://reviews.apache.org/r/51813/#comment215979> Aggree that 30 is too high but 5 is too low, how about 10 ? ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py (line 45) <https://reviews.apache.org/r/51813/#comment215977> I think this should be 10 secs linke server sice default. Rest of the settings make sense. ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py (line 76) <https://reviews.apache.org/r/51813/#comment215984> Can we do this in parallel? ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py (line 153) <https://reviews.apache.org/r/51813/#comment215980> We should log the same output as the exception since plain old message would not be meaningful in the log. - Sid Wagle On Sept. 12, 2016, 3:59 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51813/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2016, 3:59 p.m.) > > > Review request for Ambari, Aravindan Vijayan and Sid Wagle. > > > Bugs: AMBARI-17457 > https://issues.apache.org/jira/browse/AMBARI-17457 > > > Repository: ambari > > > Description > ------- > > Fix service check to andle AMS HA > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py > ddd3e42 > > Diff: https://reviews.apache.org/r/51813/diff/ > > > Testing > ------- > > Unit tests passed > > > Thanks, > > Dmytro Sen > >
