----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51894/ -----------------------------------------------------------
(Updated Sept. 14, 2016, 6:55 p.m.) Review request for Ambari, Alexandr Antonenko and Di Li. Changes ------- Updated the patch and diff to ensure the right view version is displayed when cloning instance. Also added back the empty first column (which was removed in the first patch) in the view instance list. Bugs: AMBARI-18378 https://issues.apache.org/jira/browse/AMBARI-18378 Repository: ambari Description ------- This task is for providing an option to clone / copy a view instance. A new "copy" icon will appear next to a view instance. Clicking on this opens up the existing view with instance name and display name of the view appended with _Copy. This will be useful when creating multiple view instances with mild configuration differences between them. Diffs (updated) ----- ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js 20bd25c ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 0aefaba ambari-admin/src/main/resources/ui/admin-web/app/scripts/routes.js 239e39e ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/create.html 924885f ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html bc441cd Diff: https://reviews.apache.org/r/51894/diff/ Testing ------- Manual testing with different types of view instances. Currently there are no automated tests for ambari-admin. File Attachments (updated) ---------------- AMBARI-18378.patch https://reviews.apache.org/media/uploaded/files/2016/09/14/f1299304-2bad-42d2-8509-831aba536e9a__AMBARI-18378.patch Thanks, Sangeeta Ravindran