----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51910/#review149053 -----------------------------------------------------------
Fix it, then Ship it! contrib/version-builder/version_builder.py (lines 207 - 208) <https://reviews.apache.org/r/51910/#comment216591> This is an optional element, so the builder should check for None-ness, or I suppose you could default it false in the method signature. The argument should be a boolean, so you should coerce the value to a string contrib/version-builder/version_builder.py (lines 437 - 438) <https://reviews.apache.org/r/51910/#comment216590> Should modify the --repo option help above to include --repo-unique. Also (nit): "Indicates base url should be unique" - Nate Cole On Sept. 15, 2016, 7:24 a.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51910/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2016, 7:24 a.m.) > > > Review request for Ambari, Nate Cole and Vitalyi Brodetskyi. > > > Bugs: AMBARI-18397 > https://issues.apache.org/jira/browse/AMBARI-18397 > > > Repository: ambari > > > Description > ------- > > Previous patch added a unique element to repositories that allows the backend > to determine whether a URL can be reused for other repos (HDP cannot be > reused, therefore is unique. HDP-UTILS *can* be reused, therefore > unique=false). > > Now, we need to add that to the VDF builder before we hand to RE to implement > this element. > > This entails updating the {{contrib/version-builder}} script and making sure > existing VDF without the element will still work (they better). > > > Diffs > ----- > > contrib/version-builder/example.py b9cdf56 > contrib/version-builder/example.sh bc76fd0 > contrib/version-builder/version_builder.py 2c07b0c > > Diff: https://reviews.apache.org/r/51910/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Dmitro Lisnichenko > >
