----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51961/#review149217 -----------------------------------------------------------
Ship it! Ship It! - Alejandro Fernandez On Sept. 16, 2016, 5:25 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51961/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2016, 5:25 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and > Jonathan Hurley. > > > Bugs: AMBARI-18391 > https://issues.apache.org/jira/browse/AMBARI-18391 > > > Repository: ambari > > > Description > ------- > > Updates prereq checks for specific services for VDF. > > There is another anti-pattern discovered here which will be addressed in a > future patch: we are requiring super.isAllowed() in subclasses. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java > 4bc64d4 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java > 25aa62b > > ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java > 6d5f23e > > ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java > 55c8815 > > ambari-server/src/test/java/org/apache/ambari/server/checks/MapReduce2JobHistoryStatePreservingCheckTest.java > bfe0c3e > > ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesNamenodeTruncateCheckTest.java > 87d4167 > > Diff: https://reviews.apache.org/r/51961/diff/ > > > Testing > ------- > > Tests run: 4680, Failures: 0, Errors: 0, Skipped: 36 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 36:29.565s > [INFO] Finished at: Fri Sep 16 13:14:35 EDT 2016 > [INFO] Final Memory: 35M/665M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
