----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51971/#review149259 -----------------------------------------------------------
Ship it! Ship It! - Sid Wagle On Sept. 16, 2016, 8:16 p.m., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51971/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2016, 8:16 p.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-17456 > https://issues.apache.org/jira/browse/AMBARI-17456 > > > Repository: ambari > > > Description > ------- > > Follow up bug fix for AMBARI-17456 (https://reviews.apache.org/r/51657/) > > BUG > The config_reader was expecting a string like "host1,host2" for > metrics_server_hosts, but params.py was passing in "['host1','host2']". Hence > emitter got bad hostnames like "['host1'" and "'host2']" after split. > > Also, brought back the "hostname" config in metric_monitor.ini since that can > be used to pass in the correct hostname as managed by ambari. That is used to > denote the current host rather than the collector host. > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py > 2e8a170 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2 > b011fd5 > > Diff: https://reviews.apache.org/r/51971/diff/ > > > Testing > ------- > > Manually tested > Unit tests pass. > > > Thanks, > > Aravindan Vijayan > >
