-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52038/
-----------------------------------------------------------

Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Oliver Szabo, and 
Sebastian Toader.


Bugs: AMBARI-18418
    https://issues.apache.org/jira/browse/AMBARI-18418


Repository: ambari


Description
-------

Replaced String.format placeholders with Log4J placeholders


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
 a8b4632 

Diff: https://reviews.apache.org/r/52038/diff/


Testing
-------

* Set `log4j.rootLogger=DEBUG,file` in 
`/etc/ambari-server/conf/log4j.properties`
 * Start Ambari server (no cluster needed)
 * Verify `StackServiceDirectory` messages contain service name, stack name, 
not %s placeholders
   Example:
     wrong: `19 Sep 2016 14:01:08,380 DEBUG [main] StackServiceDirectory:159 - 
Service package folder %s for service %s for stack %s does not exist.`
     good: `19 Sep 2016 14:07:22,651 DEBUG [main] StackServiceDirectory:159 - 
Service package folder 
/var/lib/ambari-server/resources/stacks/HDP/2.4/services/ACCUMULO/package for 
service ACCUMULO for stack HDP-2.4 does not exist.`


Thanks,

Attila Doroszlai

Reply via email to