> On 九月 22, 2016, 4:21 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java, > > lines 204-207 > > <https://reviews.apache.org/r/52155/diff/1/?file=1508029#file1508029line204> > > > > Wouldn't this prevent the method from being executed again? > > wang yaoxin wrote: > My first upgrade test failed due to my environment issue. Since in real > production environment this failure would occur again, I am now submit the > patch for the purpose of optimizing the entire section of code
Thnaks ,Jonathan ! - wang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52155/#review150021 ----------------------------------------------------------- On 九月 23, 2016, 4:58 a.m., wang yaoxin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52155/ > ----------------------------------------------------------- > > (Updated 九月 23, 2016, 4:58 a.m.) > > > Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, > and Sebastian Toader. > > > Bugs: AMBARI-18441 > https://issues.apache.org/jira/browse/AMBARI-18441 > > > Repository: ambari > > > Description > ------- > > ambari upgrade to 2.1.1, if the first time failed , excute ambari-server > upgrade again will error duplicate key value violates unique constraint > "pk_hostcomponentstate". > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java > db13612 > > Diff: https://reviews.apache.org/r/52155/diff/ > > > Testing > ------- > > the unit test is UpgradeCatalog211Test.java: Process finished with exit code > 0. > done ! > > > Thanks, > > wang yaoxin > >
