-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52532/
-----------------------------------------------------------
(Updated Жов. 4, 2016, 10:40 після полудня)
Review request for Ambari, Alejandro Fernandez, Robert Levas, Sumit Mohanty,
and Sid Wagle.
Bugs: AMBARI-18532
https://issues.apache.org/jira/browse/AMBARI-18532
Repository: ambari
Description
-------
blueprint_setting table incorrectly defines blueprint_name column in DDL for
MySQL:
{code:title=Current Definition}
CREATE TABLE blueprint_setting (
id BIGINT NOT NULL,
blueprint_name VARCHAR(100) NOT NULL,
setting_name VARCHAR(100) NOT NULL,
setting_data MEDIUMTEXT NOT NULL,
CONSTRAINT PK_blueprint_setting PRIMARY KEY (id),
CONSTRAINT UQ_blueprint_setting_name UNIQUE(blueprint_name,setting_name),
CONSTRAINT FK_blueprint_setting_name FOREIGN KEY (blueprint_name) REFERENCES
blueprint(blueprint_name));
{code}
{code:title=Correct Definition}
CREATE TABLE blueprint_setting (
id BIGINT NOT NULL,
blueprint_name VARCHAR(255) NOT NULL,
setting_name VARCHAR(100) NOT NULL,
setting_data MEDIUMTEXT NOT NULL,
CONSTRAINT PK_blueprint_setting PRIMARY KEY (id),
CONSTRAINT UQ_blueprint_setting_name UNIQUE(blueprint_name,setting_name),
CONSTRAINT FK_blueprint_setting_name FOREIGN KEY (blueprint_name) REFERENCES
blueprint(blueprint_name));
{code}
This will cause errors when creating the table while MySQL sets up the foreign
key constraint due to the column mismatch.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
ebfb267
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog242.java
PRE-CREATION
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql e8a2569
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
PRE-CREATION
Diff: https://reviews.apache.org/r/52532/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
