-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52646/
-----------------------------------------------------------
Review request for Ambari, Nate Cole, Robert Levas, and Sid Wagle.
Bugs: AMBARI-18556
https://issues.apache.org/jira/browse/AMBARI-18556
Repository: ambari
Description
-------
A continuation of AMBARI-18456...
The {{Service}} business object should have the following work performed:
- Remove locking around areas where its no longer required
- Replace collections with thread-safe concurrent versions
- Remove some reliance on state-full business objects (caches)
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseRequest.java
9f7b949
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
746bca4
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
ac680a5
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
56196c1
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentDesiredStateDAO.java
176e15b
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentStateDAO.java
2eefe09
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostDAO.java
d367eb3
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterServiceEntity.java
320c1be
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentDesiredStateEntity.java
fd15200
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java
1555321
ambari-server/src/main/java/org/apache/ambari/server/state/Service.java
48ab252
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java
36d4902
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
aff3a3b
ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java
ec8873a
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
7e345e5
ambari-server/src/main/java/org/apache/ambari/server/utils/RetryHelper.java
17f1447
ambari-server/src/test/java/org/apache/ambari/server/agent/HeartbeatProcessorTest.java
dd93374
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
0f48cf6
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java
503c8e5
ambari-server/src/test/java/org/apache/ambari/server/configuration/RecoveryConfigHelperTest.java
50f5abe
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
a3521fd
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProviderTest.java
6a0fa12
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java
84f8124
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java
a0940ba
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
c2c8ced
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProviderTest.java
8efec98
ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/state/GeneralServiceCalculatedStateTest.java
710c723
ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java
bdbaf9b
ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java
5280ae6
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java
d12adde
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java
480dfb3
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
d3d8b4c
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java
cfe5d61
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java
65751af
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java
c511f1a
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java
c7a5915
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java
ab2628b
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterImplTest.java
ba0ff11
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
4d39f71
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java
d2d07b5
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java
2f2be0c
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java
992b8fe
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java
0f272f6
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
7f12eb7
Diff: https://reviews.apache.org/r/52646/diff/
Testing
-------
Tests run: 4689, Failures: 0, Errors: 0, Skipped: 36
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 23:42 min
[INFO] Finished at: 2016-10-07T14:51:21-04:00
[INFO] Final Memory: 57M/742M
[INFO] ------------------------------------------------------------------------
Thanks,
Jonathan Hurley
