----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52681/#review151977 -----------------------------------------------------------
Ship it! Ship It! - Sandor Magyari On Oct. 10, 2016, 11:14 a.m., Sebastian Toader wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52681/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2016, 11:14 a.m.) > > > Review request for Ambari, Laszlo Puskas, Oliver Szabo, and Sandor Magyari. > > > Bugs: AMBARI-18560 > https://issues.apache.org/jira/browse/AMBARI-18560 > > > Repository: ambari > > > Description > ------- > > Log at INFO level the cases when commands to be sent for agents are not > created for update host component requests due to certain conditions are not > met. This will help with tracing from logs why no actions for agents were not > created by the server. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 1fc9dbf > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java > 73cedb4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java > 85a4949 > > Diff: https://reviews.apache.org/r/52681/diff/ > > > Testing > ------- > > Manual testing. > > Unit test results: > Failed tests: > UpgradeCatalog222Test.testInitializeStromAndKafkaWidgets:1118 > Unexpected method call > AmbariManagementController.initializeWidgetsAndLayouts(EasyMock for interface > org.apache.ambari.server.state.Cluster, EasyMock for interface > org.apache.ambari.server.state.Service): > AmbariManagementController.getClusters(): expected: at least 0, actual: 1 > AmbariManagementController.initializeWidgetsAndLayouts(EasyMock for > interface org.apache.ambari.server.state.Cluster, EasyMock for interface > org.apache.ambari.server.state.Service): expected: 1, actual: 0 > DataStoreImplTest.testFind:526 expected:<class > DS_DataStoreImplTest$TestEntity_1> but was:<class > DS_DataStoreImplTest$TestSubEntity_1> > DataStoreImplTest.testRemove:475 expected:<class > DS_DataStoreImplTest$TestEntity_1> but was:<class > DS_DataStoreImplTest$TestSubEntity_1> > DataStoreImplTest.testStore_update:357 expected:<class > DS_DataStoreImplTest$TestEntity_1> but was:<class > DS_DataStoreImplTest$TestSubEntity_1> > DataStoreImplTest.testStore_update_longStringValue:426 > Expectation failure on verify: > DynamicEntity.set("DS_id", 99): expected: 1, actual: 0 > > > These failure are not related to this change. > > > Thanks, > > Sebastian Toader > >
