----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52837/#review152650 -----------------------------------------------------------
Ship it! Ship It! - Robert Levas On Oct. 13, 2016, 1:17 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52837/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2016, 1:17 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Nate Cole, and Robert Levas. > > > Bugs: AMBARI-18591 > https://issues.apache.org/jira/browse/AMBARI-18591 > > > Repository: ambari > > > Description > ------- > > HS2 RU expects all users to be using zookeeper based JDBC URLs. However, few > users are using these new Zookeeper discovery urls and they use the old > format, directly specifying the hostname and port number for the HS2 instance > it connects to. During RU, the HS2 port number changes and users using old > url have an outage. Hive needs to be able to support RU without changing the > port. > > Due to too many Hive Client user outages as a result of the RU workflow for > HIve, the decision is to just change RU to bounce the HS2 process, knowing > that there will be down time and causing all active queries to fail. So the > runbook for the HS2 process will look like: > > * We will no longer change the Hive port at all during either RU or EU. > * During an RU, we will present a message if Hive is present that indicates > that Hive is not rolling and it will be taken down. > * Run the Hive deregister command to remove the ZK entries for the Hive > Servers > * Hive will be shutdown, without draining, during an RU and a new instance > started up on the same port. > > In addition, we need to remove the warnings that were added as part of > AMBARI-17319. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java > 7fdd0ce > > ambari-server/src/main/java/org/apache/ambari/server/checks/HiveNotRollingWarning.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/checks/HiveRollingPortChangeWarning.java > 3db31ea > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py > 614b2a9 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_upgrade.py > 478c240 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml > 5957da4 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml > 6920b2c > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml > 1b04237 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml > 8c5f9aa > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml > 6105665 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml > 9b9848e > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml > 51fbcbf > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml > cca4b14 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml > db59f8c > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml > 17d7d9c > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml > 921fc9c > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml > 962d92e > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml > 28b34a2 > > ambari-server/src/test/java/org/apache/ambari/server/checks/HiveNotRollingWarningTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/checks/HiveRollingPortChangeWarningTest.java > cf76d12 > > Diff: https://reviews.apache.org/r/52837/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 28:16 min > [INFO] Finished at: 2016-10-13T12:18:24-04:00 > [INFO] Final Memory: 60M/720M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Jonathan Hurley > >